Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ Feat ] Remove hostUrl from MagicLinkGenerationOptions #33

Closed
mw10013 opened this issue Dec 19, 2023 · 1 comment
Closed

[ Feat ] Remove hostUrl from MagicLinkGenerationOptions #33

mw10013 opened this issue Dec 19, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@mw10013
Copy link
Collaborator

mw10013 commented Dec 19, 2023

Remove hostUrl from MagicLinkGenerationOptions since it seems unnecessary and may even be a foot gun.

I am struggling to come up with a case where you would want to specify hostUrl explicitly because it would be different from the origin of the request url. If you do specify hostUrl and it is different from the origin of the request url, then the browser will not provide the right cookies to the magic link and you've shot yourself in the foot.

@dev-xo: Please share your thoughts and if you want to proceed, I can move it forward.

@mw10013 mw10013 self-assigned this Dec 19, 2023
@dev-xo
Copy link
Owner

dev-xo commented Dec 20, 2023

Sounds good to me, @mw10013! As I said before, it's been some time since the magic-link feature and the library has undergone a few updates. Some of the parameters/options added initially might not make sense at all nowadays.

Feel free to go for it. If the tests pass, we are as good as we can be! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants