Skip to content

Conversation

@wes-turner
Copy link
Contributor

@wes-turner wes-turner commented Mar 4, 2024

Buster is old; bookworm current.

Patch suggested by #7329 (comment).

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Buster is old; bookworm current.
@netlify
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 689bb6d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e6066d215889000871a31f

@wes-turner wes-turner marked this pull request as ready for review March 4, 2024 17:38
@wes-turner wes-turner requested a review from a team as a code owner March 4, 2024 17:38
@wes-turner wes-turner requested a review from djanicekpach March 4, 2024 17:38
@codecov
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.22%. Comparing base (fa856ab) to head (689bb6d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8943   +/-   ##
=======================================
  Coverage   47.22%   47.22%           
=======================================
  Files        1162     1162           
  Lines      175910   175910           
  Branches     2235     2235           
=======================================
  Hits        83066    83066           
  Misses      92686    92686           
  Partials      158      158           
Flag Coverage Δ
backend 42.09% <ø> (ø)
harness 63.94% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes CI, awesome. Thanks. :)

@wes-turner wes-turner changed the title test: CLI tests in CI use new Python images test: CLI workflows in CI use new Python images Mar 4, 2024
@wes-turner wes-turner merged commit d507edd into main Mar 4, 2024
@wes-turner wes-turner deleted the wes/buster-bookworm branch March 4, 2024 18:56
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants