chore: remove support for Python 3.7; prefer 3.8#7329
Merged
wes-turner merged 11 commits intomainfrom Mar 4, 2024
Merged
Conversation
✅ Deploy Preview for determined-ui canceled.
|
wes-turner
force-pushed
the
wes-bump-mypy-python
branch
from
d23de30 to
4acb0c0
Compare
wes-turner
changed the title
rb-determined-ai
approved these changes
Jul 6, 2023
Contributor
rb-determined-ai
left a comment
rb-determined-ai
left a comment
There was a problem hiding this comment.
Looks good to me!
There's still some 37 and 3.7 related things in the circleci config though.
Contributor
Author
|
Converting to "draft" pending the removal of support for TF1 (and the TF1 environments that use Python 3.7). Wheels for TF are not available for Python 3.8 (https://pypi.org/project/tensorflow/1.15.5/) |
tara-hpe
reviewed
Jul 7, 2023
| The CLI is distributed as a Python wheel package and requires Python >= 3.8. We recommend setting up | ||
| a `virtualenv <https://virtualenv.pypa.io/en/latest/>`__ and using the ``pip`` utility to install | ||
| ``determined`` into the environment: | ||
|
|
Contributor
There was a problem hiding this comment.
The command-line interface (CLI) is distributed in the form of a Python wheel package and requires Python version 3.8 or later.
(source: Microsoft Manual of Style)
wes-turner
force-pushed
the
wes-bump-mypy-python
branch
from
65b964e to
5939574
Compare
wes-turner
force-pushed
the
wes-bump-mypy-python
branch
from
b71a8fc to
e1ea5ad
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7329 +/- ##
=======================================
Coverage 47.19% 47.19%
=======================================
Files 1155 1155
Lines 175116 175101 -15
Branches 2235 2237 +2
=======================================
- Hits 82646 82639 -7
+ Misses 92312 92304 -8
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mypy used to test against python 3.7. 3.7 has passed EOL.
* unconditionally import functions added to typing in 3.8 * use copytree from shutils unconditionally (added in 3.8) * remove reference to 3.7 environments image * remove references to tf1 images from e2e_tests config
These Docker images are no longer called by reference in any current test execution.
wes-turner
force-pushed
the
wes-bump-mypy-python
branch
from
2b13982 to
214e138
Compare
wes-turner
requested review from
caehd10 and
carolinaecalderon
and removed request for
caehd10
ioga
approved these changes
Mar 1, 2024
wes-turner
changed the title
dannysauer
reviewed
Mar 4, 2024
| - image: python:3.7-slim-buster | ||
| python-38: | ||
| docker: | ||
| - image: python:3.8-slim-buster |
Contributor
There was a problem hiding this comment.
We're still using the Buster images? :D
They've moved through Bullseye and are now on Bookworm. This is probably a separate PR, but those buster images haven't been updated for about a year. docker-library/python#822
dannysauer
approved these changes
Mar 4, 2024
Contributor
dannysauer
left a comment
dannysauer
left a comment
There was a problem hiding this comment.
I didn't do a grep -R or anything, but this LGTM.
4 tasks
Contributor
|
yay, finally! |
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Python 3.7 is EOL. * Some docs that referred to 3.7 now refer to 3.8 * Training API "how to" doc no longer mentions any 3.7 docker images * `CONTRIBUTING.md` no longer says to upgrade pip when installing determined * `CONTRIBUTING.md` has revised text about Python requirements * mypy tests against 3.8. * Features new to 3.8 can be used without suppressing type checking or conditional imports. These changes have been made. * No longer run `test-cli` in CircleCI against Python 3.7. * There are no wheels for TF1 using Python 3.8. Removing 3.7 support means TF1 cannot be used. In previous commits, we removed support of TF1. We also clean up those references here. In particular: - `e2e_tests/tests/command/test_run:test_k8_init_containers` and `e2e_tests/tests/command/test_run:test_k8_sidecars` now run on TF2 images - Removed references to TF1 images in `e2e_tests`. - Removed references to TF1 Docker images in `bumpenvs.yaml`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.7 is EOL.
CONTRIBUTING.mdno longer says to upgrade pip when installing determinedCONTRIBUTING.mdhas revised text about Python requirementstest-cliin CircleCI against Python 3.7.e2e_tests/tests/command/test_run:test_k8_init_containersande2e_tests/tests/command/test_run:test_k8_sidecarsnow run on TF2 imagese2e_tests.bumpenvs.yamlDescription
Test Plan
tests are green
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket