Repository navigation
Conversation
🤖 PR meta 🤖🏷️ LabelsThis pull request needs exactly one label indicating its type, and has 0.
Read more about Type labels in Gutenberg. If you cannot add labels yourself, a reviewer can do it for you. |
desrosj
changed the base branch from
fix-actions-5.9/update-php-test-matrix
to
wp/5.9
October 7, 2026 18:02
desrosj
force-pushed
the
fix-actions-5.9/remove-phpunit-watcher
branch
from
October 7, 2026 18:04
b0022e9 to
645eafa
Compare
desrosj
changed the base branch from
wp/5.9
to
fix-actions-5.9/update-php-test-matrix
October 7, 2026 18:05
desrosj
force-pushed
the
fix-actions-5.9/remove-phpunit-watcher
branch
from
October 8, 2026 19:35
645eafa to
ff897ab
Compare
desrosj
marked this pull request as ready for review
October 9, 2026 16:35
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Moved to WordPress#84404. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
spatie/phpunit-watcherdev dependency fromcomposer.jsonandcomposer.lock, along with thetest:watchComposer script and thetest-php:watchnpm script that only ran it.Why?
The PHPUnit matrix in #392 adds PHP
5.6and7.0jobs.spatie/phpunit-watcherrequires PHP 7.2+ and pulls insymfony/polyfill-php80,symfony/stringandsymfony/deprecation-contracts. Their bootstrap files are listed invendor/composer/autoload_files.php, so PHP has to parse them before theirPHP_VERSION_IDguards run.php -lon the installed files inphp:5.6-cli(5.6.40) andphp:7.0-cli(7.0.33):autoload_files.phpentrysymfony/polyfill-php80/bootstrap.php255255symfony/string/Resources/functions.php255255symfony/deprecation-contracts/function.php2550phpunit/bootstrap.phprequiresvendor/autoload.php, so those jobs fail before any test runs.Removing the package in a workflow step doesn't work on this branch, because it commits a
composer.lock:composer remove spatie/phpunit-watcher --dev --no-updateonly editscomposer.json, and the followingcomposer installwarns that the lock is out of date and installs the package again from the lock.wp/6.0makes the same change in WordPress#84272.How?
composer.lockwas regenerated withcomposer update spatie/phpunit-watcher(a partial update, not a fullcomposer update), which reported0 installs, 0 updates, 22 removals:spatie/phpunit-watcher's dependency tree;symfony/polyfill-ctypestays because other packages still require it.content-hash,plugin-api-version(2.1.0→2.9.0), andplatform,platform-devandstability-flagswritten as{}instead of[].Testing
With #341's
config.platform.phpon top:composer installexits0with no lock warning.vendor/spatieandvendor/symfony/polyfill-php80are gone.vendor/composer/autoload_files.phppassesphp -lunder PHP 5.6 and 7.0.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.
🤖 Generated with Claude Code