Skip to content

Repair wp/5.9 branch Actions: Add a PHP-version test matrix - #392

Closed
desrosj wants to merge 1 commit into
fix-actions-5.9/docker-compose-v2from
fix-actions-5.9/update-php-test-matrix
Closed

desrosj wants to merge 1 commit into
fix-actions-5.9/docker-compose-v2from
fix-actions-5.9/update-php-test-matrix

Conversation

@desrosj

@desrosj desrosj commented Sep 21, 2026 •

Copy link
Copy Markdown
Owner

What?

Runs the PHPUnit job in unit-test.yml across a PHP version matrix: 5.6, 7.0, 7.4, 8.0 and 8.1, each as a single site and a multisite leg.

  • WP_ENV_PHP_VERSION is set from the matrix, so wp-env uses the matching wordpress:php<version> images.
  • The single site and multisite test steps, which both ran in the one job, now each run in their own leg.

Why?

.wp-env.json sets no phpVersion, so the job ran once, on whatever PHP version the floating wordpress images use, which this branch was never written for. The matrix tests the lowest and highest supported minor version of each major PHP version.

How?

This branch's packages/env already reads WP_ENV_PHP_VERSION, so only the workflow changes. Composer still installs dependencies inside wp-env's composer container, from the committed composer.lock. Related PRs in this stack:

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

🤖 Generated with Claude Code

@desrosj
desrosj added this pull request to stack #395 September 21, 2026 16:56
@desrosj
desrosj removed this pull request from stack #395 September 21, 2026 16:57
@desrosj
desrosj added this pull request to stack #396 September 21, 2026 16:57
@desrosj
desrosj removed this pull request from stack #396 September 22, 2026 16:02
@desrosj
desrosj changed the base branch from fix-actions-5.9/fix-workflow-branch-filters to wp/5.9 September 22, 2026 16:02
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from cb95d72 to 6e7946d Compare September 22, 2026 16:04
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/pin-wp-env-composer-php-version September 22, 2026 16:04
@desrosj
desrosj added this pull request to stack #463 September 22, 2026 16:04
@desrosj
desrosj removed this pull request from stack #463 September 22, 2026 21:19
@desrosj
desrosj changed the base branch from fix-actions-5.9/pin-wp-env-composer-php-version to wp/5.9 September 22, 2026 21:19
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 6e7946d to 593836d Compare September 22, 2026 21:36
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/pin-wp-env-composer-php-version September 22, 2026 21:37
@desrosj
desrosj added this pull request to stack #483 September 22, 2026 21:37
@desrosj
desrosj removed this pull request from stack #483 September 23, 2026 01:33
@desrosj
desrosj changed the base branch from fix-actions-5.9/pin-wp-env-composer-php-version to wp/5.9 September 23, 2026 01:33
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 593836d to 70da22c Compare September 23, 2026 01:52
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/pin-wp-env-composer-php-version September 23, 2026 01:52
@desrosj
desrosj added this pull request to stack #490 September 23, 2026 01:52
@desrosj
desrosj removed this pull request from stack #490 September 23, 2026 21:23
@desrosj
desrosj changed the base branch from fix-actions-5.9/pin-wp-env-composer-php-version to wp/5.9 September 23, 2026 21:24
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 70da22c to 1a48a86 Compare September 23, 2026 21:26
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/pin-wp-env-composer-php-version September 23, 2026 21:27
@desrosj
desrosj added this pull request to stack #498 September 23, 2026 21:27
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 1a48a86 to 122341a Compare September 24, 2026 00:41
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 122341a to f889f39 Compare September 24, 2026 02:18
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/docker-compose-v2 September 24, 2026 18:23
@desrosj
desrosj added this pull request to stack #530 September 24, 2026 18:23
@desrosj
desrosj removed this pull request from stack #530 September 28, 2026 19:13
@desrosj
desrosj changed the base branch from fix-actions-5.9/docker-compose-v2 to wp/5.9 September 28, 2026 19:13
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from feb5fba to d92cdbb Compare September 28, 2026 19:13
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/docker-compose-v2 September 28, 2026 19:14
@desrosj
desrosj added this pull request to stack #570 September 28, 2026 19:14
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from d92cdbb to 97f95b3 Compare October 5, 2026 20:48
@desrosj
desrosj removed this pull request from stack #570 October 5, 2026 20:49
@desrosj
desrosj added this pull request to stack #616 October 5, 2026 20:49
@desrosj
desrosj removed this pull request from stack #616 October 6, 2026 18:27
@desrosj
desrosj added this pull request to stack #636 October 6, 2026 18:28
@desrosj
desrosj removed this pull request from stack #636 October 7, 2026 00:58
@desrosj
desrosj added this pull request to stack #643 October 7, 2026 00:59
@desrosj
desrosj removed this pull request from stack #643 October 7, 2026 18:02
@desrosj
desrosj changed the base branch from fix-actions-5.9/docker-compose-v2 to wp/5.9 October 7, 2026 18:02
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from 97f95b3 to df17dbc Compare October 7, 2026 18:04
@desrosj
desrosj changed the base branch from wp/5.9 to fix-actions-5.9/docker-compose-v2 October 7, 2026 18:05
@desrosj
desrosj added this pull request to stack #668 October 7, 2026 18:06
Previously, the `unit-php` job ran on whatever PHP version the
untagged `wordpress`/`wordpress:cli` Docker images happened to
default to, and always ran both the single-site and multisite suites
sequentially in the same job run. This meant no PHP version was
actually pinned or verified, and a failure in one suite could mask or
be masked by the other.

Add a `strategy.matrix` testing PHP 5.6, 7.0, 7.4, 8.0, and 8.1 (the
lowest and highest supported minor per major PHP version this branch
supports), with `multisite: [false, true]` as a second axis so the
existing single-site and multisite runs become independent, isolated
legs instead of two steps in one run. `WP_ENV_PHP_VERSION` is set at
the job level so `wp-env`'s Docker Compose config pulls the matching
PHP-tagged `wordpress`/`wordpress:cli`/`wordpressdevelop/phpunit`
images for each leg. `fail-fast` is set to `false` so a failure on
one PHP version doesn't cancel the runs still verifying the others.
@desrosj
desrosj removed this pull request from stack #668 October 8, 2026 19:35
@desrosj
desrosj force-pushed the fix-actions-5.9/update-php-test-matrix branch from df17dbc to ff92f05 Compare October 8, 2026 19:35
@desrosj
desrosj added this pull request to stack #695 October 8, 2026 19:35
@desrosj
desrosj marked this pull request as ready for review October 9, 2026 16:32
@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj

desrosj commented Oct 9, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84403.

@desrosj desrosj closed this Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant