Skip to content

Repair wp/6.3 branch Actions: Exclude the firefox project from Playwright (reliable browser-context crash) - #381

Closed
desrosj wants to merge 1 commit into
fix-actions-6.3/fix-flaky-openverse-image-drag-and-drop-testfrom
fix-actions-6.3/exclude-firefox-playwright-crash
Closed

desrosj wants to merge 1 commit into
fix-actions-6.3/fix-flaky-openverse-image-drag-and-drop-testfrom
fix-actions-6.3/exclude-firefox-playwright-crash

Conversation

@desrosj

@desrosj desrosj commented Sep 17, 2026 •

Copy link
Copy Markdown
Owner

What?

Excludes the firefox project from the Playwright job's (e2e-playwright) test run in .github/workflows/end2end-test.yml on wp/6.3, alongside webkit (already excluded by the fix-playwright-noble-install layer). Also drops the now-unused libdbus-glib-1-2 system-package install step, since it existed solely to satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

Why?

This branch is pinned to @playwright/test@1.32.0 (.nvmrc is Node 14, leaving no headroom to bump it the way branches with newer Node, e.g. wp/6.5/wp/6.6, already did). On this pinned version, every real run of the firefox project on the ubuntu-24.04 runner reliably crashes partway through with browserContext.newPage: Page closed, which then cascades identical Page closed failures through the rest of that worker's queued tests.

This is not test-content flakiness: playwright.config.ts already sets workers: 1/retries: 2, and every retry of every affected test fails with the exact same error, because the underlying Firefox browser process itself has died for the rest of the worker's run, not an individual test or page.

Confirmed reproducing identically, not a one-off — two independent runs on the current top-of-stack PR (#352) both showed all Playwright - 4 failures as [firefox]-only browserContext.newPage: Page closed cascades, chromium unaffected. This matches the same class already fixed the same way on wp/6.2 (#359).

This is a permanent, environment/version-locked gap on this frozen branch, only fixable by bumping @playwright/test — out of scope for a CI-repair PR. Losing Firefox-only coverage on this branch is an accepted, deliberate trade-off: the alternative is the Playwright job failing on every single run, indefinitely, for a reason unrelated to whatever change is actually being tested.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj added this pull request to stack #351 September 17, 2026 03:00
@desrosj
desrosj removed this pull request from stack #351 September 21, 2026 18:35
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 21, 2026 18:37
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from 42dd990 to db1b91a Compare September 21, 2026 18:46
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 21, 2026 18:48
@desrosj
desrosj added this pull request to stack #403 September 21, 2026 18:48
@desrosj
desrosj removed this pull request from stack #403 September 21, 2026 19:36
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 21, 2026 19:38
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from db1b91a to 5040e37 Compare September 21, 2026 19:49
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 21, 2026 19:52
@desrosj
desrosj added this pull request to stack #420 September 21, 2026 19:52
@desrosj
desrosj removed this pull request from stack #420 September 21, 2026 21:06
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 21, 2026 21:07
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from 5040e37 to 07a9695 Compare September 21, 2026 21:17
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 21, 2026 21:33
@desrosj
desrosj added this pull request to stack #424 September 21, 2026 21:33
@desrosj
desrosj removed this pull request from stack #424 September 21, 2026 23:48
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 21, 2026 23:48
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from 07a9695 to cf2fbf7 Compare September 21, 2026 23:49
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 21, 2026 23:51
@desrosj
desrosj added this pull request to stack #436 September 21, 2026 23:51
@desrosj
desrosj removed this pull request from stack #436 September 22, 2026 15:45
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 22, 2026 15:46
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 22, 2026 15:49
@desrosj
desrosj added this pull request to stack #459 September 22, 2026 15:49
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from cf2fbf7 to dd894eb Compare September 22, 2026 15:54
@desrosj
desrosj removed this pull request from stack #459 September 22, 2026 20:16
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 22, 2026 20:16
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from dd894eb to 135b5e3 Compare September 22, 2026 20:19
@desrosj
desrosj removed this pull request from stack #486 September 24, 2026 17:11
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 24, 2026 17:11
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from ce07535 to 059b7e0 Compare September 24, 2026 17:12
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 24, 2026 17:14
@desrosj
desrosj added this pull request to stack #511 September 24, 2026 17:15
@desrosj
desrosj removed this pull request from stack #511 September 24, 2026 17:44
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 24, 2026 17:44
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from 059b7e0 to 2c4d398 Compare September 24, 2026 17:45
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 24, 2026 17:45
@desrosj
desrosj added this pull request to stack #515 September 24, 2026 17:45
@desrosj
desrosj removed this pull request from stack #515 September 28, 2026 14:31
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 28, 2026 14:31
@desrosj
desrosj force-pushed the fix-actions-6.3/exclude-firefox-playwright-crash branch from 2c4d398 to 2b6a14d Compare September 28, 2026 14:32
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-e2e-tests September 28, 2026 14:32
@desrosj
desrosj added this pull request to stack #537 September 28, 2026 14:32
@desrosj
desrosj removed this pull request from stack #537 September 28, 2026 15:24
@desrosj
desrosj changed the base branch from fix-actions-6.3/fix-flaky-e2e-tests to wp/6.3 September 28, 2026 15:24
@desrosj
desrosj changed the base branch from wp/6.3 to fix-actions-6.3/fix-flaky-openverse-image-drag-and-drop-test September 28, 2026 15:25
@desrosj
desrosj added this pull request to stack #552 September 28, 2026 15:25
…xt crash).

This branch is pinned to `@playwright/test@1.32.0` (`.nvmrc` is Node 14, leaving no headroom to bump it the way branches with newer Node already did). On this pinned version, every real run of the `firefox` project on the `ubuntu-24.04` runner reliably crashes partway through with `browserContext.newPage: Page closed`, which then cascades identical `Page closed` failures through the rest of that worker's queued tests.

This is not test-content flakiness: `playwright.config.ts` already sets `workers: 1`/`retries: 2`, and every retry of every affected test fails with the exact same error, because the underlying Firefox browser process itself has died for the rest of the worker's run, not an individual test or page.

This is a permanent, environment/version-locked gap on this frozen branch, only fixable by bumping `@playwright/test`, which is out of scope for a CI-repair PR. Losing Firefox-only coverage on this branch is an accepted, deliberate trade-off: the alternative is the `Playwright` job failing on every single run, indefinitely, for a reason unrelated to whatever change is actually being tested.
@desrosj

desrosj commented Sep 28, 2026

Copy link
Copy Markdown
Owner Author

No longer needed: #290 now runs the Playwright job on ubuntu-22.04, where Firefox doesn't crash. Validated in #560 (all 628 tests across chromium, firefox and webkit passed). The branch is kept in case this approach is needed again once ubuntu-22.04 runners are retired.

@desrosj desrosj closed this Sep 28, 2026
@desrosj
desrosj removed this pull request from stack #552 September 28, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant