Repository navigation
Repair wp/6.3 branch Actions: Exclude the firefox project from Playwright (reliable browser-context crash) - #381
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 21, 2026 18:37
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 21, 2026 18:46
42dd990 to
db1b91a
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 21, 2026 18:48
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 21, 2026 19:38
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 21, 2026 19:49
db1b91a to
5040e37
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 21, 2026 19:52
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 21, 2026 21:07
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 21, 2026 21:17
5040e37 to
07a9695
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 21, 2026 21:33
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 21, 2026 23:48
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 21, 2026 23:49
07a9695 to
cf2fbf7
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 21, 2026 23:51
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 22, 2026 15:46
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 22, 2026 15:49
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 22, 2026 15:54
cf2fbf7 to
dd894eb
Compare
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 22, 2026 20:16
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 22, 2026 20:19
dd894eb to
135b5e3
Compare
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 24, 2026 17:11
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 24, 2026 17:12
ce07535 to
059b7e0
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 24, 2026 17:14
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 24, 2026 17:44
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 24, 2026 17:45
059b7e0 to
2c4d398
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 24, 2026 17:45
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 28, 2026 14:31
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 28, 2026 14:32
2c4d398 to
2b6a14d
Compare
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-e2e-tests
September 28, 2026 14:32
desrosj
changed the base branch from
fix-actions-6.3/fix-flaky-e2e-tests
to
wp/6.3
September 28, 2026 15:24
desrosj
changed the base branch from
wp/6.3
to
fix-actions-6.3/fix-flaky-openverse-image-drag-and-drop-test
September 28, 2026 15:25
…xt crash). This branch is pinned to `@playwright/test@1.32.0` (`.nvmrc` is Node 14, leaving no headroom to bump it the way branches with newer Node already did). On this pinned version, every real run of the `firefox` project on the `ubuntu-24.04` runner reliably crashes partway through with `browserContext.newPage: Page closed`, which then cascades identical `Page closed` failures through the rest of that worker's queued tests. This is not test-content flakiness: `playwright.config.ts` already sets `workers: 1`/`retries: 2`, and every retry of every affected test fails with the exact same error, because the underlying Firefox browser process itself has died for the rest of the worker's run, not an individual test or page. This is a permanent, environment/version-locked gap on this frozen branch, only fixable by bumping `@playwright/test`, which is out of scope for a CI-repair PR. Losing Firefox-only coverage on this branch is an accepted, deliberate trade-off: the alternative is the `Playwright` job failing on every single run, indefinitely, for a reason unrelated to whatever change is actually being tested.
desrosj
force-pushed
the
fix-actions-6.3/exclude-firefox-playwright-crash
branch
from
September 28, 2026 17:36
2b6a14d to
0df62f3
Compare
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Excludes the
firefoxproject from thePlaywrightjob's (e2e-playwright) test run in.github/workflows/end2end-test.ymlonwp/6.3, alongsidewebkit(already excluded by thefix-playwright-noble-installlayer). Also drops the now-unusedlibdbus-glib-1-2system-package install step, since it existed solely to satisfy Firefox's one runtime dependency and Chromium needs nothing extra.Why?
This branch is pinned to
@playwright/test@1.32.0(.nvmrcis Node 14, leaving no headroom to bump it the way branches with newer Node, e.g.wp/6.5/wp/6.6, already did). On this pinned version, every real run of thefirefoxproject on theubuntu-24.04runner reliably crashes partway through withbrowserContext.newPage: Page closed, which then cascades identicalPage closedfailures through the rest of that worker's queued tests.This is not test-content flakiness:
playwright.config.tsalready setsworkers: 1/retries: 2, and every retry of every affected test fails with the exact same error, because the underlying Firefox browser process itself has died for the rest of the worker's run, not an individual test or page.Confirmed reproducing identically, not a one-off — two independent runs on the current top-of-stack PR (#352) both showed all
Playwright - 4failures as[firefox]-onlybrowserContext.newPage: Page closedcascades,chromiumunaffected. This matches the same class already fixed the same way onwp/6.2(#359).This is a permanent, environment/version-locked gap on this frozen branch, only fixable by bumping
@playwright/test— out of scope for a CI-repair PR. Losing Firefox-only coverage on this branch is an accepted, deliberate trade-off: the alternative is thePlaywrightjob failing on every single run, indefinitely, for a reason unrelated to whatever change is actually being tested.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.