Skip to content

Repair wp/6.2 branch Actions: Remove the broken flaky-test-to-GitHub-issues reporting job - #358

Closed
desrosj wants to merge 1 commit into
fix-actions-6.2/fix-workflow-branch-filtersfrom
fix-actions-6.2/disable-flaky-test-issue-reporting
Closed

desrosj wants to merge 1 commit into
fix-actions-6.2/fix-workflow-branch-filtersfrom
fix-actions-6.2/disable-flaky-test-issue-reporting

Conversation

@desrosj

@desrosj desrosj commented Sep 15, 2026

Copy link
Copy Markdown
Owner

What?

Removes the report-to-issues job (Report to GitHub) from .github/workflows/end2end-test.yml on wp/6.2.

Why?

report-to-issues checks out trunk (ref: trunk) rather than this branch, then runs npm run build:packages before invoking ./packages/report-flaky-tests — it always builds and runs live current trunk's copy of the action, never wp/6.2's own frozen copy.

Trunk has since removed the build:packages script from package.json as part of migrating report-flaky-tests to run directly from its TypeScript sources via Node 24's native type stripping (no build step: using: 'node24', main: 'src/index.ts' in trunk's packages/report-flaky-tests/action.yml). As a result, the job's npm run build:packages step fails with npm error Missing script: "build:packages" whenever it actually reaches that step — which it does whenever e2e-puppeteer/e2e-playwright produce a flaky-tests-report artifact for it to pick up.

This is directly confirmed as the currently-failing top-of-stack check, not just inferred from trunk's content: on PR #346 (the previous top of stack), the End-to-End Tests workflow's Report to GitHub job failed with exactly this error — run 34801278771, job 103934457687.

This is a structural failure, not a one-time regression: because the job always tracks a moving target (trunk) instead of this branch's own pinned copy, it will keep breaking as trunk's tooling around this action continues to evolve, independent of anything in wp/6.2 itself.

Retrofitting trunk's current version of report-flaky-tests was considered and rejected, matching the same decision already made on wp/6.3-wp/6.8 (where this same layer, disable-flaky-test-issue-reporting, already exists). Trunk's rewrite is also a product-policy change — flaky tests are now reported as PR comments only, and no longer filed as GitHub issues — which is out of scope for a frozen, security-maintenance-only branch.

Removing the job only drops an automated notification; no actual test-correctness signal depends on it. packages/report-flaky-tests is left in place on this branch, now unused by any workflow — removing the package itself is optional cleanup out of scope for this fix.

Testing

Diff mirrors the already-proven disable-flaky-test-issue-reporting layer used on wp/6.3-wp/6.8 (e.g. #134 on wp/6.3) — same job removed, same shape (this branch has no separate merge-artifacts/has-flaky-test-report gate to also touch). Will confirm this specific branch's Report to GitHub check goes from failing to not-present/passing via real CI on this PR before it's finalized.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj self-assigned this Sep 15, 2026
@desrosj
desrosj added this pull request to stack #350 September 15, 2026 04:34
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from 03ba428 to 6264969 Compare September 15, 2026 19:20
@desrosj
desrosj removed this pull request from stack #350 September 21, 2026 21:45
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-mariadb-client-debug-step to wp/6.2 September 21, 2026 21:46
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from 6264969 to c6a4e40 Compare September 21, 2026 21:49
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-mariadb-client-debug-step September 21, 2026 21:51
@desrosj
desrosj added this pull request to stack #427 September 21, 2026 21:51
@desrosj
desrosj removed this pull request from stack #427 September 21, 2026 23:47
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-mariadb-client-debug-step to wp/6.2 September 21, 2026 23:48
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from c6a4e40 to 11d16dd Compare September 21, 2026 23:49
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-mariadb-client-debug-step September 21, 2026 23:50
@desrosj
desrosj added this pull request to stack #435 September 21, 2026 23:51
@desrosj
desrosj removed this pull request from stack #435 September 22, 2026 15:49
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-mariadb-client-debug-step to wp/6.2 September 22, 2026 15:50
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 22, 2026 15:53
@desrosj
desrosj added this pull request to stack #460 September 22, 2026 15:53
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from 11d16dd to 7b6d787 Compare September 22, 2026 15:53
@desrosj
desrosj removed this pull request from stack #460 September 22, 2026 20:20
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 September 22, 2026 20:20
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from 7b6d787 to efade38 Compare September 22, 2026 20:22
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 22, 2026 20:36
@desrosj
desrosj added this pull request to stack #478 September 22, 2026 20:36
@desrosj
desrosj removed this pull request from stack #478 September 23, 2026 01:31
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 September 23, 2026 01:31
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 23, 2026 01:44
@desrosj
desrosj added this pull request to stack #487 September 23, 2026 01:44
@desrosj
desrosj removed this pull request from stack #487 September 24, 2026 17:15
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 September 24, 2026 17:15
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 24, 2026 17:17
@desrosj
desrosj added this pull request to stack #513 September 24, 2026 17:18
@desrosj
desrosj removed this pull request from stack #513 September 24, 2026 17:45
@desrosj
desrosj added this pull request to stack #516 September 24, 2026 17:46
@desrosj
desrosj removed this pull request from stack #516 September 28, 2026 14:33
@desrosj
desrosj added this pull request to stack #539 September 28, 2026 14:34
@desrosj
desrosj removed this pull request from stack #539 September 28, 2026 19:05
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 September 28, 2026 19:05
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 28, 2026 19:06
@desrosj
desrosj added this pull request to stack #567 September 28, 2026 19:07
@desrosj
desrosj removed this pull request from stack #567 September 28, 2026 19:20
@desrosj
desrosj added this pull request to stack #572 September 28, 2026 19:21
@desrosj
desrosj marked this pull request as ready for review September 28, 2026 19:34
@desrosj
desrosj removed this pull request from stack #572 September 29, 2026 00:24
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 September 29, 2026 00:24
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters September 29, 2026 00:25
@desrosj
desrosj added this pull request to stack #573 September 29, 2026 00:26
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj removed this pull request from stack #573 October 6, 2026 23:39
@desrosj
desrosj added this pull request to stack #637 October 6, 2026 23:44
…st.yml`.

Removes the `report-to-issues` job (`Report to GitHub`) from
`.github/workflows/end2end-test.yml`.

`report-to-issues` checks out `trunk` (`ref: trunk`) and then runs `npm run
build:packages` before invoking `./packages/report-flaky-tests` — it always
builds and runs live current trunk's copy of the action, never this frozen
branch's own. Trunk has since removed the `build:packages` script from
`package.json` as part of migrating `report-flaky-tests` to run directly from
its TypeScript sources via Node 24's native type stripping, with no build
step (`using: 'node24'`, `main: 'src/index.ts'`), so the job's build step now
fails with `npm error Missing script: "build:packages"` whenever it reaches
that point.

Confirmed live and current on this branch, not just inferred: PR #346's own
`Report to GitHub` job failed on run 34801278771/job 103934457687 with
exactly this error, after `npm ci`/`postinstall` completed against trunk's
current `package.json`.

This is a structural failure, not a one-time regression: because the job
always tracks a moving target (trunk) rather than the branch's own pinned
copy, it will keep breaking as trunk's tooling around this action continues
to evolve, regardless of anything in this branch. Retrofitting trunk's
current version was considered and rejected — trunk's rewrite also drops
GitHub-issue filing for flaky tests in favor of PR-comment-only reporting, a
product-policy change out of scope for a frozen, security-maintenance-only
branch. This mirrors the same fix already applied as the
`disable-flaky-test-issue-reporting` layer on `wp/6.3`-`wp/6.8`.

Removing the job only drops an automated notification; no test-correctness
signal depends on it. `packages/report-flaky-tests` is left in place,
now unused by any workflow on this branch — removing it is optional cleanup
out of scope here.

# Conflicts:
#	.github/workflows/end2end-test.yml
@desrosj
desrosj removed this pull request from stack #637 October 7, 2026 17:51
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-workflow-branch-filters to wp/6.2 October 7, 2026 17:52
@desrosj
desrosj force-pushed the fix-actions-6.2/disable-flaky-test-issue-reporting branch from efade38 to 26da3e5 Compare October 7, 2026 17:54
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-workflow-branch-filters October 7, 2026 17:55
@desrosj
desrosj added this pull request to stack #666 October 7, 2026 17:56
@desrosj

desrosj commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

Moved to WordPress#84220.

@desrosj desrosj closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant