Skip to content

Repair wp/6.2 branch Actions: Use mariadb client instead of removed mysql in Docker container debug step - #346

Closed
desrosj wants to merge 1 commit into
fix-actions-6.2/fix-activate-theme-navigation-racefrom
fix-actions-6.2/fix-mariadb-client-debug-step
Closed

desrosj wants to merge 1 commit into
fix-actions-6.2/fix-activate-theme-navigation-racefrom
fix-actions-6.2/fix-mariadb-client-debug-step

Conversation

@desrosj

@desrosj desrosj commented Sep 14, 2026 •

Copy link
Copy Markdown
Owner

What?

Runs mariadb --version instead of mysql --version in unit-test.yml's "Docker container debug information" step.

Why?

wp-env's database container uses the unversioned mariadb image. MariaDB 11.0 removed the mysql alias for its mariadb client, so on current images the step fails with mysql: not found, and the PHP jobs fail before PHPUnit runs. WordPress Core's test environment makes the same distinction (WordPress/wordpress-develop@ea80ac8): it uses mysql only for MariaDB 10.3 and earlier, which have no mariadb client.

trunk made the same switch to mariadb in WordPress/gutenberg#75341, as part of a larger wp-env change. That version of the line uses trunk's newer wp-env-test command, so only the binary name is changed here.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj desrosj self-assigned this Sep 14, 2026
@desrosj
desrosj added this pull request to stack #321 September 14, 2026 00:29
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-docker-compose-v2-debug-step branch from 7bdcbf0 to b7acd1f Compare September 14, 2026 01:33
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch 2 times, most recently from e187eb5 to cb96dd8 Compare September 14, 2026 03:03
@desrosj
desrosj removed this pull request from stack #321 September 14, 2026 03:05
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-docker-compose-v2-debug-step to fix-actions-6.2/fix-playwright-noble-install September 14, 2026 03:05
@desrosj
desrosj added this pull request to stack #350 September 14, 2026 03:05
desrosj added a commit that referenced this pull request Sep 15, 2026
…ntu 24.04.

This branch is pinned to `@playwright/test@1.30.0` (`.nvmrc` is Node 14,
leaving no headroom to bump it — the version bump used on branches with
newer Node, e.g. `wp/6.5`/`wp/6.6`, isn't available here). On this pinned
version, every real run of the `firefox` project on the `ubuntu-24.04`
runner reliably crashes partway through with `browserContext.newPage: Page
closed`, which then cascades identical `Page closed` failures through the
rest of that worker's queued tests. This is not test-content flakiness:
`workers: 1`/`retries: 2` are already set in `playwright.config.ts`, and
every retry of every affected test fails with the exact same error, because
the underlying Firefox browser process itself has died for the rest of the
worker's run, not an individual test/page.

Confirmed reproducing identically, not a one-off: PR #346's own `Playwright`
job (the previous top of stack) failed with 379 passed / 24 failed, every
failure in the `[firefox]` project only (`chromium`: zero failures), all in
`autocomplete-and-mentions.spec.js`/`inserting-blocks.spec.js`/
`a11y-region-navigation.spec.js` — run 34801278771, job 103899920125. This is
the identical signature (same pass/fail counts, same spec files) already
documented against this branch's `fix-playwright-noble-install` layer (PR
#281) in an earlier CI run, and matches the same `firefox`-only browser-
context-crash class already seen (and left as pre-existing, out-of-scope
noise) on several sibling `wp/6.x` branches that also lack Node headroom to
bump `@playwright/test`.

`chromium` is unaffected in both runs. `webkit` is already excluded from
this job (by the `fix-playwright-noble-install` layer, for an unrelated
reason: no installable binary for it on Ubuntu 24.04 with this pinned
Playwright version) — this commit drops `firefox` from the same install
step and `--project` list, for this distinct reason, and removes the
`libdbus-glib-1-2` system-package install step since it existed solely to
satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

This is a permanent, environment/version-locked gap on this frozen branch,
only fixable by bumping `@playwright/test` — out of scope for this PR. Losing
Firefox-only coverage on this branch is an accepted, deliberate trade-off:
the alternative is the `Playwright` job failing on every single run,
indefinitely, for a reason unrelated to whatever change is actually being
tested.
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-playwright-noble-install branch from a349d08 to 6709efa Compare September 15, 2026 19:20
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from cb96dd8 to 1e12e56 Compare September 15, 2026 19:20
desrosj added a commit that referenced this pull request Sep 15, 2026
…st.yml`.

Removes the `report-to-issues` job (`Report to GitHub`) from
`.github/workflows/end2end-test.yml`.

`report-to-issues` checks out `trunk` (`ref: trunk`) and then runs `npm run
build:packages` before invoking `./packages/report-flaky-tests` — it always
builds and runs live current trunk's copy of the action, never this frozen
branch's own. Trunk has since removed the `build:packages` script from
`package.json` as part of migrating `report-flaky-tests` to run directly from
its TypeScript sources via Node 24's native type stripping, with no build
step (`using: 'node24'`, `main: 'src/index.ts'`), so the job's build step now
fails with `npm error Missing script: "build:packages"` whenever it reaches
that point.

Confirmed live and current on this branch, not just inferred: PR #346's own
`Report to GitHub` job failed on run 34801278771/job 103934457687 with
exactly this error, after `npm ci`/`postinstall` completed against trunk's
current `package.json`.

This is a structural failure, not a one-time regression: because the job
always tracks a moving target (trunk) rather than the branch's own pinned
copy, it will keep breaking as trunk's tooling around this action continues
to evolve, regardless of anything in this branch. Retrofitting trunk's
current version was considered and rejected — trunk's rewrite also drops
GitHub-issue filing for flaky tests in favor of PR-comment-only reporting, a
product-policy change out of scope for a frozen, security-maintenance-only
branch. This mirrors the same fix already applied as the
`disable-flaky-test-issue-reporting` layer on `wp/6.3`-`wp/6.8`.

Removing the job only drops an automated notification; no test-correctness
signal depends on it. `packages/report-flaky-tests` is left in place,
now unused by any workflow on this branch — removing it is optional cleanup
out of scope here.
desrosj added a commit that referenced this pull request Sep 15, 2026
…ntu 24.04.

This branch is pinned to `@playwright/test@1.30.0` (`.nvmrc` is Node 14,
leaving no headroom to bump it — the version bump used on branches with
newer Node, e.g. `wp/6.5`/`wp/6.6`, isn't available here). On this pinned
version, every real run of the `firefox` project on the `ubuntu-24.04`
runner reliably crashes partway through with `browserContext.newPage: Page
closed`, which then cascades identical `Page closed` failures through the
rest of that worker's queued tests. This is not test-content flakiness:
`workers: 1`/`retries: 2` are already set in `playwright.config.ts`, and
every retry of every affected test fails with the exact same error, because
the underlying Firefox browser process itself has died for the rest of the
worker's run, not an individual test/page.

Confirmed reproducing identically, not a one-off: PR #346's own `Playwright`
job (the previous top of stack) failed with 379 passed / 24 failed, every
failure in the `[firefox]` project only (`chromium`: zero failures), all in
`autocomplete-and-mentions.spec.js`/`inserting-blocks.spec.js`/
`a11y-region-navigation.spec.js` — run 34801278771, job 103899920125. This is
the identical signature (same pass/fail counts, same spec files) already
documented against this branch's `fix-playwright-noble-install` layer (PR
#281) in an earlier CI run, and matches the same `firefox`-only browser-
context-crash class already seen (and left as pre-existing, out-of-scope
noise) on several sibling `wp/6.x` branches that also lack Node headroom to
bump `@playwright/test`.

`chromium` is unaffected in both runs. `webkit` is already excluded from
this job (by the `fix-playwright-noble-install` layer, for an unrelated
reason: no installable binary for it on Ubuntu 24.04 with this pinned
Playwright version) — this commit drops `firefox` from the same install
step and `--project` list, for this distinct reason, and removes the
`libdbus-glib-1-2` system-package install step since it existed solely to
satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

This is a permanent, environment/version-locked gap on this frozen branch,
only fixable by bumping `@playwright/test` — out of scope for this PR. Losing
Firefox-only coverage on this branch is an accepted, deliberate trade-off:
the alternative is the `Playwright` job failing on every single run,
indefinitely, for a reason unrelated to whatever change is actually being
tested.
@desrosj
desrosj removed this pull request from stack #350 September 21, 2026 21:45
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-playwright-noble-install to wp/6.2 September 21, 2026 21:46
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from 1e12e56 to b2c1d71 Compare September 21, 2026 21:49
desrosj added a commit that referenced this pull request Sep 21, 2026
…st.yml`.

Removes the `report-to-issues` job (`Report to GitHub`) from
`.github/workflows/end2end-test.yml`.

`report-to-issues` checks out `trunk` (`ref: trunk`) and then runs `npm run
build:packages` before invoking `./packages/report-flaky-tests` — it always
builds and runs live current trunk's copy of the action, never this frozen
branch's own. Trunk has since removed the `build:packages` script from
`package.json` as part of migrating `report-flaky-tests` to run directly from
its TypeScript sources via Node 24's native type stripping, with no build
step (`using: 'node24'`, `main: 'src/index.ts'`), so the job's build step now
fails with `npm error Missing script: "build:packages"` whenever it reaches
that point.

Confirmed live and current on this branch, not just inferred: PR #346's own
`Report to GitHub` job failed on run 34801278771/job 103934457687 with
exactly this error, after `npm ci`/`postinstall` completed against trunk's
current `package.json`.

This is a structural failure, not a one-time regression: because the job
always tracks a moving target (trunk) rather than the branch's own pinned
copy, it will keep breaking as trunk's tooling around this action continues
to evolve, regardless of anything in this branch. Retrofitting trunk's
current version was considered and rejected — trunk's rewrite also drops
GitHub-issue filing for flaky tests in favor of PR-comment-only reporting, a
product-policy change out of scope for a frozen, security-maintenance-only
branch. This mirrors the same fix already applied as the
`disable-flaky-test-issue-reporting` layer on `wp/6.3`-`wp/6.8`.

Removing the job only drops an automated notification; no test-correctness
signal depends on it. `packages/report-flaky-tests` is left in place,
now unused by any workflow on this branch — removing it is optional cleanup
out of scope here.
desrosj added a commit that referenced this pull request Sep 21, 2026
…ntu 24.04.

This branch is pinned to `@playwright/test@1.30.0` (`.nvmrc` is Node 14,
leaving no headroom to bump it — the version bump used on branches with
newer Node, e.g. `wp/6.5`/`wp/6.6`, isn't available here). On this pinned
version, every real run of the `firefox` project on the `ubuntu-24.04`
runner reliably crashes partway through with `browserContext.newPage: Page
closed`, which then cascades identical `Page closed` failures through the
rest of that worker's queued tests. This is not test-content flakiness:
`workers: 1`/`retries: 2` are already set in `playwright.config.ts`, and
every retry of every affected test fails with the exact same error, because
the underlying Firefox browser process itself has died for the rest of the
worker's run, not an individual test/page.

Confirmed reproducing identically, not a one-off: PR #346's own `Playwright`
job (the previous top of stack) failed with 379 passed / 24 failed, every
failure in the `[firefox]` project only (`chromium`: zero failures), all in
`autocomplete-and-mentions.spec.js`/`inserting-blocks.spec.js`/
`a11y-region-navigation.spec.js` — run 34801278771, job 103899920125. This is
the identical signature (same pass/fail counts, same spec files) already
documented against this branch's `fix-playwright-noble-install` layer (PR
#281) in an earlier CI run, and matches the same `firefox`-only browser-
context-crash class already seen (and left as pre-existing, out-of-scope
noise) on several sibling `wp/6.x` branches that also lack Node headroom to
bump `@playwright/test`.

`chromium` is unaffected in both runs. `webkit` is already excluded from
this job (by the `fix-playwright-noble-install` layer, for an unrelated
reason: no installable binary for it on Ubuntu 24.04 with this pinned
Playwright version) — this commit drops `firefox` from the same install
step and `--project` list, for this distinct reason, and removes the
`libdbus-glib-1-2` system-package install step since it existed solely to
satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

This is a permanent, environment/version-locked gap on this frozen branch,
only fixable by bumping `@playwright/test` — out of scope for this PR. Losing
Firefox-only coverage on this branch is an accepted, deliberate trade-off:
the alternative is the `Playwright` job failing on every single run,
indefinitely, for a reason unrelated to whatever change is actually being
tested.
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-playwright-noble-install September 21, 2026 21:51
@desrosj
desrosj added this pull request to stack #427 September 21, 2026 21:51
@desrosj
desrosj removed this pull request from stack #427 September 21, 2026 23:47
@desrosj
desrosj changed the base branch from fix-actions-6.2/fix-playwright-noble-install to wp/6.2 September 21, 2026 23:48
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from b2c1d71 to 0ed2020 Compare September 21, 2026 23:49
desrosj added a commit that referenced this pull request Sep 21, 2026
…st.yml`.

Removes the `report-to-issues` job (`Report to GitHub`) from
`.github/workflows/end2end-test.yml`.

`report-to-issues` checks out `trunk` (`ref: trunk`) and then runs `npm run
build:packages` before invoking `./packages/report-flaky-tests` — it always
builds and runs live current trunk's copy of the action, never this frozen
branch's own. Trunk has since removed the `build:packages` script from
`package.json` as part of migrating `report-flaky-tests` to run directly from
its TypeScript sources via Node 24's native type stripping, with no build
step (`using: 'node24'`, `main: 'src/index.ts'`), so the job's build step now
fails with `npm error Missing script: "build:packages"` whenever it reaches
that point.

Confirmed live and current on this branch, not just inferred: PR #346's own
`Report to GitHub` job failed on run 34801278771/job 103934457687 with
exactly this error, after `npm ci`/`postinstall` completed against trunk's
current `package.json`.

This is a structural failure, not a one-time regression: because the job
always tracks a moving target (trunk) rather than the branch's own pinned
copy, it will keep breaking as trunk's tooling around this action continues
to evolve, regardless of anything in this branch. Retrofitting trunk's
current version was considered and rejected — trunk's rewrite also drops
GitHub-issue filing for flaky tests in favor of PR-comment-only reporting, a
product-policy change out of scope for a frozen, security-maintenance-only
branch. This mirrors the same fix already applied as the
`disable-flaky-test-issue-reporting` layer on `wp/6.3`-`wp/6.8`.

Removing the job only drops an automated notification; no test-correctness
signal depends on it. `packages/report-flaky-tests` is left in place,
now unused by any workflow on this branch — removing it is optional cleanup
out of scope here.
desrosj added a commit that referenced this pull request Sep 21, 2026
…ntu 24.04.

This branch is pinned to `@playwright/test@1.30.0` (`.nvmrc` is Node 14,
leaving no headroom to bump it — the version bump used on branches with
newer Node, e.g. `wp/6.5`/`wp/6.6`, isn't available here). On this pinned
version, every real run of the `firefox` project on the `ubuntu-24.04`
runner reliably crashes partway through with `browserContext.newPage: Page
closed`, which then cascades identical `Page closed` failures through the
rest of that worker's queued tests. This is not test-content flakiness:
`workers: 1`/`retries: 2` are already set in `playwright.config.ts`, and
every retry of every affected test fails with the exact same error, because
the underlying Firefox browser process itself has died for the rest of the
worker's run, not an individual test/page.

Confirmed reproducing identically, not a one-off: PR #346's own `Playwright`
job (the previous top of stack) failed with 379 passed / 24 failed, every
failure in the `[firefox]` project only (`chromium`: zero failures), all in
`autocomplete-and-mentions.spec.js`/`inserting-blocks.spec.js`/
`a11y-region-navigation.spec.js` — run 34801278771, job 103899920125. This is
the identical signature (same pass/fail counts, same spec files) already
documented against this branch's `fix-playwright-noble-install` layer (PR
#281) in an earlier CI run, and matches the same `firefox`-only browser-
context-crash class already seen (and left as pre-existing, out-of-scope
noise) on several sibling `wp/6.x` branches that also lack Node headroom to
bump `@playwright/test`.

`chromium` is unaffected in both runs. `webkit` is already excluded from
this job (by the `fix-playwright-noble-install` layer, for an unrelated
reason: no installable binary for it on Ubuntu 24.04 with this pinned
Playwright version) — this commit drops `firefox` from the same install
step and `--project` list, for this distinct reason, and removes the
`libdbus-glib-1-2` system-package install step since it existed solely to
satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

This is a permanent, environment/version-locked gap on this frozen branch,
only fixable by bumping `@playwright/test` — out of scope for this PR. Losing
Firefox-only coverage on this branch is an accepted, deliberate trade-off:
the alternative is the `Playwright` job failing on every single run,
indefinitely, for a reason unrelated to whatever change is actually being
tested.
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-playwright-noble-install September 21, 2026 23:50
@desrosj
desrosj changed the base branch from fix-actions-6.2/exclude-firefox-playwright-crash to wp/6.2 September 23, 2026 01:31
desrosj added a commit that referenced this pull request Sep 23, 2026
…ntu 24.04.

This branch is pinned to `@playwright/test@1.30.0` (`.nvmrc` is Node 14,
leaving no headroom to bump it — the version bump used on branches with
newer Node, e.g. `wp/6.5`/`wp/6.6`, isn't available here). On this pinned
version, every real run of the `firefox` project on the `ubuntu-24.04`
runner reliably crashes partway through with `browserContext.newPage: Page
closed`, which then cascades identical `Page closed` failures through the
rest of that worker's queued tests. This is not test-content flakiness:
`workers: 1`/`retries: 2` are already set in `playwright.config.ts`, and
every retry of every affected test fails with the exact same error, because
the underlying Firefox browser process itself has died for the rest of the
worker's run, not an individual test/page.

Confirmed reproducing identically, not a one-off: PR #346's own `Playwright`
job (the previous top of stack) failed with 379 passed / 24 failed, every
failure in the `[firefox]` project only (`chromium`: zero failures), all in
`autocomplete-and-mentions.spec.js`/`inserting-blocks.spec.js`/
`a11y-region-navigation.spec.js` — run 34801278771, job 103899920125. This is
the identical signature (same pass/fail counts, same spec files) already
documented against this branch's `fix-playwright-noble-install` layer (PR
#281) in an earlier CI run, and matches the same `firefox`-only browser-
context-crash class already seen (and left as pre-existing, out-of-scope
noise) on several sibling `wp/6.x` branches that also lack Node headroom to
bump `@playwright/test`.

`chromium` is unaffected in both runs. `webkit` is already excluded from
this job (by the `fix-playwright-noble-install` layer, for an unrelated
reason: no installable binary for it on Ubuntu 24.04 with this pinned
Playwright version) — this commit drops `firefox` from the same install
step and `--project` list, for this distinct reason, and removes the
`libdbus-glib-1-2` system-package install step since it existed solely to
satisfy Firefox's one runtime dependency and Chromium needs nothing extra.

This is a permanent, environment/version-locked gap on this frozen branch,
only fixable by bumping `@playwright/test` — out of scope for this PR. Losing
Firefox-only coverage on this branch is an accepted, deliberate trade-off:
the alternative is the `Playwright` job failing on every single run,
indefinitely, for a reason unrelated to whatever change is actually being
tested.
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from 1e2ce5e to f4e8249 Compare September 23, 2026 01:44
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/exclude-firefox-playwright-crash September 23, 2026 01:44
@desrosj
desrosj added this pull request to stack #487 September 23, 2026 01:44
@desrosj
desrosj removed this pull request from stack #487 September 24, 2026 17:15
@desrosj
desrosj changed the base branch from fix-actions-6.2/exclude-firefox-playwright-crash to wp/6.2 September 24, 2026 17:16
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from f4e8249 to 33f87ba Compare September 24, 2026 17:17
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/exclude-firefox-playwright-crash September 24, 2026 17:18
@desrosj
desrosj added this pull request to stack #513 September 24, 2026 17:18
@desrosj
desrosj removed this pull request from stack #513 September 24, 2026 17:45
@desrosj
desrosj changed the base branch from fix-actions-6.2/exclude-firefox-playwright-crash to wp/6.2 September 24, 2026 17:45
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from 33f87ba to 9fbb0f5 Compare September 24, 2026 17:46
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/exclude-firefox-playwright-crash September 24, 2026 17:46
@desrosj
desrosj added this pull request to stack #516 September 24, 2026 17:46
@desrosj
desrosj removed this pull request from stack #516 September 28, 2026 14:33
@desrosj
desrosj changed the base branch from fix-actions-6.2/exclude-firefox-playwright-crash to wp/6.2 September 28, 2026 14:33
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from 9fbb0f5 to 7d42d44 Compare September 28, 2026 14:33
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/exclude-firefox-playwright-crash September 28, 2026 14:34
@desrosj
desrosj added this pull request to stack #539 September 28, 2026 14:34
@desrosj
desrosj removed this pull request from stack #539 September 28, 2026 19:05
@desrosj
desrosj changed the base branch from fix-actions-6.2/exclude-firefox-playwright-crash to wp/6.2 September 28, 2026 19:05
@desrosj
desrosj force-pushed the fix-actions-6.2/fix-mariadb-client-debug-step branch from 7d42d44 to 88323f2 Compare September 28, 2026 19:06
@desrosj
desrosj changed the base branch from wp/6.2 to fix-actions-6.2/fix-activate-theme-navigation-race September 28, 2026 19:07
@desrosj
desrosj added this pull request to stack #567 September 28, 2026 19:07
@desrosj
desrosj removed this pull request from stack #567 September 28, 2026 19:20
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

…ntainer debug step.

`unit-test.yml`'s "Docker container debug information" step runs
`wp-env run tests-mysql "mysql --version"` purely to log the database
server's version for debugging. The `mariadb` Docker image (an
unversioned, floating tag) no longer ships a `mysql`-named client
binary at all — only `mariadb`/`mariadb-admin` — so this call fails
outright with `mysql: not found` (exit 127), which takes down the
entire job (and, via fail-fast, every other PHP version in the
matrix) even though `wp-env start` and every actual test step after
it would otherwise succeed.

Confirmed directly on this branch's own real CI: `wp-env start`
completes successfully ("WordPress development site started"), then
this debug step's very first line kills the job before any PHPUnit
test ever runs.

Trunk hit and fixed the identical problem by switching its own
equivalent step from `mysql` to `mariadb` (its current
`unit-test.yml` runs `wp-env-test -- run mysql mariadb -- --version`,
using the newer `wp-env-test` CLI wrapper's argument order — not
directly portable to this branch's older `wp-env run <service>
"<command>"` syntax, but the underlying client-binary rename is the
same fix). This change keeps this branch's existing step shape and
service name (`tests-mysql`) exactly as they are, only swapping the
renamed client binary.
@desrosj

desrosj commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

Closing in favor of #590, which now makes the full change: it replaces mysql --version in the Docker container debug step with a check that runs mariadb --version when the database container has a mariadb client and mysql --version when it doesn't. That works on every MySQL and MariaDB version, where a hardcoded mariadb only works on MariaDB 10.4 and later.

#590 now sits directly above #578 in the wp/6.2 stack (WordPress#637). The stack's final content is unchanged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant