Skip to content

Repair wp/7.1 branch Actions: update test-php job's PHP version matrix - #271

Closed
desrosj wants to merge 1 commit into
fix-actions-7.1/add-workflow-concurrencyfrom
fix-actions-7.1/update-php-test-matrix
Closed

desrosj wants to merge 1 commit into
fix-actions-7.1/add-workflow-concurrencyfrom
fix-actions-7.1/update-php-test-matrix

Conversation

@desrosj

@desrosj desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Owner

What?

Trims the test-php job's PHP version matrix in .github/workflows/unit-test.yml from 7 entries down to 3: 7.4, 8.0, 8.5.

Before: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4', '8.5']
After: ['7.4', '8.0', '8.5']

Why?

Per WordPress core's PHP compatibility policy, wp/7.1 supports PHP 7.4, and 8.0 through 8.5. This branch-repair effort's testing convention is to exercise only the lowest and highest supported minor version within each supported major version, not every minor in between (and to test a major only once if it has just one supported minor). Applying that here: PHP 7.x has only 7.4 in the supported range, so it's tested once; PHP 8.x is tested at its lowest (8.0) and highest (8.5) supported minors.

The existing matrix tested every 8.x minor individually, which is more coverage than the convention calls for and inconsistent with how sibling maintenance branches in this repair effort are configured.

Nothing else in the test-php job or file was touched — multisite:, the exclude: PR-restriction block, if: conditions, runs-on:, and concurrency: are all unchanged.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj added this pull request to stack #177 September 11, 2026 15:31
@desrosj
desrosj force-pushed the fix-actions-7.1/update-php-test-matrix branch from b26049a to 1639c38 Compare September 11, 2026 15:51
@desrosj
desrosj force-pushed the fix-actions-7.1/update-php-test-matrix branch from 1639c38 to 5b2e162 Compare September 11, 2026 17:00
@desrosj
desrosj force-pushed the fix-actions-7.1/update-php-test-matrix branch from 5b2e162 to 487e9f1 Compare September 11, 2026 17:05
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 17:57
@github-actions

Copy link
Copy Markdown

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Required label: Any label starting with [Type].
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-7.1/update-php-test-matrix branch from 487e9f1 to 59d9203 Compare September 11, 2026 18:27
@desrosj
desrosj removed this pull request from stack #177 September 11, 2026 18:31
@desrosj
desrosj changed the base branch from fix-actions-7.1/fix-wp-env-debian-bullseye to fix-actions-7.1/add-workflow-concurrency September 11, 2026 18:31
@desrosj
desrosj added this pull request to stack #278 September 11, 2026 18:33
@github-actions

Copy link
Copy Markdown

🤖 PR meta 🤖

📦 Bundle size

Size Change: +1.3 kB (+0.02%)

Total Size: 7.75 MB

📦 View Changed
Filename Size Change
build/modules/vips/worker.min.js 3.69 MB +102 B (0%)
build/scripts/block-editor/index.min.js 428 kB +80 B (+0.02%)
build/scripts/block-library/index.min.js 355 kB +409 B (+0.12%)
build/scripts/edit-post/index.min.js 52.9 kB +28 B (+0.05%)
build/scripts/edit-site/index.min.js 305 kB +3 B (0%)
build/scripts/editor/index.min.js 502 kB +278 B (+0.06%)
build/scripts/media-utils/index.min.js 121 kB +4 B (0%)
build/scripts/upload-media/index.min.js 16.5 kB +179 B (+1.1%)
build/styles/block-library/accordion-panel/style-rtl.css 118 B +41 B (+53.25%) 🆘
build/styles/block-library/accordion-panel/style-rtl.min.css 110 B +40 B (+57.14%) 🆘
build/styles/block-library/accordion-panel/style.css 118 B +41 B (+53.25%) 🆘
build/styles/block-library/accordion-panel/style.min.css 110 B +40 B (+57.14%) 🆘
build/styles/block-library/style-rtl.css 22.4 kB +14 B (+0.06%)
build/styles/block-library/style-rtl.min.css 18.9 kB +11 B (+0.06%)
build/styles/block-library/style.css 22.6 kB +15 B (+0.07%)
build/styles/block-library/style.min.css 18.9 kB +11 B (+0.06%)

59d9203 Run

Per WordPress core's PHP compatibility policy
(https://make.wordpress.org/core/handbook/references/php-compatibility-and-wordpress-versions/),
`wp/7.1` supports PHP 7.4, and 8.0 through 8.5. This project's testing
convention only exercises the lowest and highest supported minor version
within each supported major version, not every minor in between, since
minor-version testing within a single major rarely surfaces behavior
differences that changing majors does.

The `test-php` job's matrix in `.github/workflows/unit-test.yml` tested
every minor from `8.0` through `8.5` individually (`7.4, 8.0, 8.1, 8.2,
8.3, 8.4, 8.5`), which is more coverage than the convention calls for and
inconsistent with how other maintenance branches in this repair effort
are configured. Trimmed the `php:` matrix to `7.4, 8.0, 8.5` (7.4 is the
only supported 7.x minor; 8.0 and 8.5 are the lowest and highest
supported 8.x minors).
@desrosj
desrosj force-pushed the fix-actions-7.1/update-php-test-matrix branch from 59d9203 to 0019698 Compare September 11, 2026 20:28
@desrosj

desrosj commented Sep 11, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82795. Closing this fork PR.

@desrosj desrosj closed this Sep 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant