Repository navigation
Repair wp/6.5 branch Actions: Remove the broken flaky-test-to-GitHub-issues reporting job - #135
Closed
desrosj wants to merge 1 commit into
Conversation
desrosj
removed this pull request from stack #87
September 10, 2026 19:37
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 10, 2026 19:40
682feca to
c16692e
Compare
desrosj
added this pull request to stack #190
September 10, 2026 19:40
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 11, 2026 00:04
c16692e to
3f49564
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 11, 2026 00:29
3f49564 to
fdfeea7
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 11, 2026 01:15
fdfeea7 to
275ddf5
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 11, 2026 02:19
275ddf5 to
20053c6
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
2 times, most recently
from
September 11, 2026 16:08
2be4e7e to
51acb23
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
2 times, most recently
from
September 13, 2026 02:50
e1d6973 to
64da41b
Compare
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
2 times, most recently
from
September 14, 2026 17:37
4ff569c to
53e82dc
Compare
…2end-test.yml`. The `report-to-issues` job in `end2end-test.yml` (display name "Report to GitHub") always does `actions/checkout ... ref: trunk`, so it builds and runs live current trunk's `packages/report-flaky-tests` action, never this frozen branch's own copy. Trunk has since retired the `build:packages` npm script this job's "Npm build" step calls, as part of migrating the action to run straight from TypeScript source via Node 24's native type-stripping (WordPress#81218, "Flaky tests: Report as a PR comment only, stop creating issues"). Trunk's current `package.json` has no `build:packages` script at all, so the step will fail with `npm error Missing script: "build:packages"` the moment it actually executes. That step is gated behind a successful `actions/download-artifact` for a `flaky-tests-report` artifact that `e2e-puppeteer` and `e2e-playwright` only produce when a test genuinely flakes (fails, then passes on retry); no `merge-artifacts`-style job or `has-flaky-test-report` output exists on this branch to gate it instead. In every `end2end-test.yml` run checked across this branch's CI history, that precondition hadn't been met recently, so this exact failure hasn't shown up live yet here. The mechanism is nonetheless current and confirmed directly against trunk's `package.json`, and will fire the next time a genuinely flaky test occurs on this branch. Retrofitting the job to match trunk's current implementation was considered and rejected: trunk's replacement is also a real product-policy change (flaky tests become PR-comments-only, no more GitHub issues filed), which is out of scope for a frozen, security-maintenance-only branch. Removing the job only drops an automated notification; no test-correctness signal depends on it. `packages/report-flaky-tests` is left in place, now unused by any workflow on this branch; removing the package itself is optional cleanup out of scope here.
desrosj
force-pushed
the
fix-actions-6.5/disable-flaky-test-issue-reporting
branch
from
September 15, 2026 19:23
53e82dc to
897d399
Compare
desrosj
removed this pull request from stack #190
September 15, 2026 21:18
desrosj
added this pull request to stack #376
September 15, 2026 21:22
desrosj
marked this pull request as ready for review
September 15, 2026 23:36
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Owner
Author
|
Migrated to the real |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Removes the
report-to-issuesjob (display name "Report to GitHub") fromend2end-test.ymlonwp/6.5. Unlikewp/6.8(#130), this branch has nomerge-artifactsjob orhas-flaky-test-reportoutput feeding it —e2e-puppeteerande2e-playwrighteach upload aflaky-tests-reportartifact directly, andreport-to-issuesdepends on both directly (needs: [e2e-puppeteer, e2e-playwright],if: always()).Why?
report-to-issueschecks out livetrunkbefore runningpackages/report-flaky-tests, rather than this frozen branch's own copy. Trunk retired thebuild:packagesnpm script this job calls, as part of migrating the action to run directly from TypeScript source via Node 24's native type-stripping (WordPress/gutenberg#81218) — the step will fail withnpm error Missing script: "build:packages"the next time it actually runs (it's gated onsteps.download_artifact.outcome == 'success', i.e. only when a test genuinely flakes, so it hasn't fired yet on this branch, but it's the identical failure mode already confirmed and fixed onwp/6.8via #130).Retrofitting the job to match trunk's current implementation was rejected: trunk's replacement is also a real product-policy change (flaky tests become PR-comments-only, no more GitHub issues filed), out of scope for a frozen, security-maintenance-only branch. Removing the job only drops an automated notification; no test-correctness signal depends on it.
packages/report-flaky-testsis left in place, unused by any workflow on this branch — removing the package itself is optional cleanup out of scope here.Use of AI Tools
This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.