Skip to content

Repair wp/6.8 branch Actions: Remove the broken flaky-test-to-GitHub-issues reporting job - #130

Closed
desrosj wants to merge 1 commit into
fix-actions-6.8/fix-wp-env-debian-busterfrom
fix-actions-6.8/disable-flaky-test-issue-reporting
Closed

desrosj wants to merge 1 commit into
fix-actions-6.8/fix-wp-env-debian-busterfrom
fix-actions-6.8/disable-flaky-test-issue-reporting

Conversation

@desrosj

@desrosj desrosj commented Aug 31, 2026

Copy link
Copy Markdown
Owner

What?

Removes the report-to-issues job from end2end-test.yml (and the now-unused has-flaky-test-report output on merge-artifacts that fed it).

Why?

This job checks out live trunk — not this branch — before building and running ./packages/report-flaky-tests, and has been failing outright with Missing script: "build:packages". Trunk retired that npm script when it migrated this action to run directly from TypeScript source via Node 24's native type stripping, avoiding a build step entirely (WordPress/gutenberg#81218).

Because the job always tracks trunk's current state rather than a fixed target, this isn't a one-time regression to patch — it will keep breaking as trunk's build tooling continues to evolve, on every frozen branch that still has this job shape.

Retrofitting trunk's rewritten action was considered. It's technically feasible (the package is a self-contained leaf with no other consumers in the repo), but was rejected for this frozen, security-maintenance-only branch: trunk's rewrite is also a real product-policy change — flaky tests are now only commented on the PR, never filed as GitHub issues — which is more than a CI repair. Removing the job entirely only drops an automated notification; it doesn't affect any actual test-pass/fail signal, and the failure was easy to miss since the job only ever ran when merge-artifacts.outputs.has-flaky-test-report == 'true'.

packages/report-flaky-tests itself is left in place — it's now unused by any workflow on this branch, but removing the package is a separate, optional cleanup beyond this job fix.

Use of AI Tools

This PR was created by Claude Code under my supervision. All code should be treated as AI-produced and not yet reviewed by a human until this PR is marked Ready for Review.

@desrosj
desrosj removed this pull request from stack #86 September 10, 2026 19:35
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 9bc8d03 to de146bb Compare September 10, 2026 19:37
@desrosj
desrosj added this pull request to stack #187 September 10, 2026 19:37
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from de146bb to 86faa69 Compare September 11, 2026 00:05
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 86faa69 to c53d57a Compare September 11, 2026 00:29
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from c53d57a to 957ec70 Compare September 11, 2026 01:15
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 957ec70 to 77f4e18 Compare September 11, 2026 02:18
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 77f4e18 to a4fa04f Compare September 11, 2026 02:23
@desrosj
desrosj marked this pull request as ready for review September 11, 2026 02:41
@desrosj
desrosj marked this pull request as draft September 11, 2026 03:21
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: desrosj <desrosj@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from a4fa04f to 478194b Compare September 11, 2026 16:09
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 478194b to 6ab82c1 Compare September 11, 2026 17:01
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 6ab82c1 to d65188b Compare September 14, 2026 01:50
@desrosj
desrosj marked this pull request as ready for review September 14, 2026 17:49
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from d65188b to 7c7dd54 Compare September 14, 2026 17:55
…st.yml`.

The `report-to-issues` job checks out live `trunk` (not this branch) and
runs `npm run build:packages` against it before invoking
`./packages/report-flaky-tests`. Trunk retired that script as part of
migrating this action to Node 24's native TypeScript stripping
(WordPress#81218), so the job now fails outright with
`Missing script: "build:packages"` on every run. Because the job always
tracks trunk's current state rather than a fixed target, this isn't a
one-time regression — it will keep breaking as trunk's build tooling
continues to evolve, on every frozen branch that still has this job.

Retrofitting trunk's rewritten, build-free version of this action was
considered, but rejected for this frozen, security-maintenance-only
branch: it's a real, if minor, product-policy change (issues become
PR comments), not just a CI repair. Removing the job entirely only
drops an automated notification, not any actual test-correctness
signal, and the failure is otherwise silent — `if: needs.merge-artifacts.
outputs.has-flaky-test-report == 'true'` meant the job was skipped
whenever there was nothing to report, so this was easy to miss.

Also removes the now-unused `has-flaky-test-report` output it was the
sole consumer of. `packages/report-flaky-tests` itself is left in place,
now unused by any workflow on this branch.
@desrosj
desrosj force-pushed the fix-actions-6.8/disable-flaky-test-issue-reporting branch from 7c7dd54 to e306eef Compare September 14, 2026 18:43
@desrosj

desrosj commented Sep 14, 2026

Copy link
Copy Markdown
Owner Author

Migrated to real upstream: WordPress#82889. Closing this fork PR.

@desrosj desrosj closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant