Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Akmal / feat: re-trigger barrier validation to show any error messages hidden that were hidden behind th e action sheet #17571

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+837 −199
Open

Akmal / feat: re-trigger barrier validation to show any error messages hidden that were hidden behind th e action sheet #17571

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
682ab15
feat: re-trigger barrier validation to show any error messages hidden…
akmal-deriv Nov 19, 2024
b20f098
chore: update quill-ui librare
akmal-deriv Nov 19, 2024
59414c4
chore: update quill version
akmal-deriv Nov 21, 2024
3ca72c5
chore: recreate package-lock
akmal-deriv Nov 21, 2024
78af124
Merge branch 'master' into f-snackbar-fix
akmal-deriv Nov 22, 2024
58f55b2
fix: merge conflict?
akmal-deriv Nov 22, 2024
dfffa26
chore: regenerate package-lock and revert pre-commit change in app.tsx
akmal-deriv Nov 22, 2024
80f0cf3
chore: regenerate package-lock and revert pre-commit change in app.tsx
akmal-deriv Nov 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6,381 changes: 5,056 additions & 1,325 deletions package-lock.json
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/account/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@deriv-com/utils": "^0.0.36",
"@deriv-com/ui": "1.36.4",
"@deriv/api": "^1.0.0",
"@deriv-com/quill-ui": "1.21.0",
"@deriv-com/quill-ui": "1.23.1",
"@deriv/components": "^1.0.0",
"@deriv/hooks": "^1.0.0",
"@deriv/quill-icons": "1.23.3",
Expand Down
2 changes: 1 addition & 1 deletion packages/bot-web-ui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
"webpack-cli": "^5.1.4"
},
"dependencies": {
"@deriv-com/quill-ui": "1.21.0",
"@deriv-com/quill-ui": "1.23.1",
"@deriv-com/ui": "1.36.4",
"@deriv/api": "^1.0.0",
"@deriv/api-types": "1.0.172",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"@datadog/browser-rum": "^5.11.0",
"@deriv-com/analytics": "1.26.2",
"@deriv-com/quill-tokens": "2.0.4",
"@deriv-com/quill-ui": "1.21.0",
"@deriv-com/quill-ui": "1.23.1",
"@deriv-com/translations": "1.3.9",
"@deriv-com/ui": "1.36.4",
"@deriv-com/utils": "^0.0.36",
Expand Down
2 changes: 1 addition & 1 deletion packages/trader/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
"dependencies": {
"@deriv-com/analytics": "1.26.2",
"@deriv-com/quill-tokens": "2.0.4",
"@deriv-com/quill-ui": "1.21.0",
"@deriv-com/quill-ui": "1.23.1",
"@deriv-com/utils": "^0.0.36",
"@deriv-com/ui": "1.36.4",
"@deriv/api-types": "1.0.172",
Expand Down
5 changes: 5 additions & 0 deletions packages/trader/src/AppV2/Components/TradeParameters/Barrier/barrier-input.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,11 @@ const BarrierInput = observer(
onAction: () => {
if (validation_errors.barrier_1.length === 0) {
onClose(true);

// This is a workaround to re-trigger any validation errors that were hidden behind the action sheet
handleOnChange({
target: { name: 'barrier_1', value: barrier_1.replace(/[+-]/g, '') },
});
} else {
setShouldShowError(true);
}
Expand Down