Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Akmal / feat: re-trigger barrier validation to show any error messages hidden that were hidden behind th e action sheet #17571

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

akmal-deriv
Copy link
Contributor

@akmal-deriv akmal-deriv commented Nov 19, 2024

Changes:

This feature re-triggers barrier validation to ensure any hidden error messages are displayed, even if they were obscured by the action sheet.

  1. Validation Refresh: Automatically revalidate barriers to surface any hidden error messages when necessary.
  2. Improved Error Visibility: Ensure users can see and address validation errors that might have been hidden behind the action sheet.
  3. Enhanced Workflow: Streamline the process of identifying and resolving input errors, reducing potential confusion.

This feature enhances error handling by ensuring barrier validation messages are always visible to the user.

Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 22, 2024 10:47am

Copy link
Contributor

github-actions bot commented Nov 19, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17571](https://github.com/deriv-com/deriv-app/pull/17571)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-akmal-deriv-f-snackbar-fix.binary.sx?qa_server=red.derivws.com&app_id=32214
    - **Original**: https://deriv-app-git-fork-akmal-deriv-f-snackbar-fix.binary.sx
- **App ID**: `32214`

Copy link
Contributor

github-actions bot commented Nov 19, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 33
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-snackbar-fix.binary.sx/

@coveralls
Copy link

coveralls commented Nov 19, 2024

Pull Request Test Coverage Report for Build 11970765507

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 126 unchanged lines in 10 files lost coverage.
  • Overall coverage increased (+0.01%) to 53.91%

Files with Coverage Reduction New Missed Lines %
packages/wallets/src/features/cfd/flows/MT5/AddedMT5AccountsList/AddedMT5AccountsList.tsx 1 91.11%
packages/wallets/src/features/cfd/modals/TradingPlatformStatusModal/TradingPlatformStatusModal.tsx 1 50.0%
packages/wallets/src/features/cfd/components/PlatformStatusBadge/PlatformStatusBadge.tsx 4 12.5%
packages/wallets/src/features/cashier/modules/Transfer/components/TransferFormAmountInput/TransferFormAmountInput.tsx 5 92.16%
packages/wallets/src/features/cfd/screens/TradingPlatformStatus/TradingPlatformStatus.tsx 6 15.38%
packages/api-v2/src/hooks/useTradingPlatformStatus.ts 7 7.69%
packages/wallets/src/features/cashier/modules/Transfer/provider/TransferProvider.tsx 11 57.14%
packages/cashier/src/stores/general-store.ts 20 69.84%
packages/core/src/App/Components/Layout/Header/toggle-menu-drawer.jsx 29 42.99%
packages/core/src/App/Containers/AccountSwitcher/account-switcher.jsx 42 43.23%
Totals Coverage Status
Change from base Build 11951696863: 0.01%
Covered Lines: 32678
Relevant Lines: 56591

💛 - Coveralls

nijil-deriv
nijil-deriv previously approved these changes Nov 21, 2024
dan-deriv
dan-deriv previously approved these changes Nov 22, 2024
vinu-deriv
vinu-deriv previously approved these changes Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants