-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Akmal / feat: re-trigger barrier validation to show any error messages hidden that were hidden behind th e action sheet #17571
Open
akmal-deriv
wants to merge
8
commits into
deriv-com:master
Choose a base branch
from
akmal-deriv:f-snackbar-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+837
−199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akmal-deriv
requested review from
nijil-deriv,
vinu-deriv,
wojciech-deriv,
ali-hosseini-deriv,
amina-deriv,
balakrishna-deriv,
farrah-deriv,
habib-deriv,
matin-deriv,
sandeep-deriv,
yashim-deriv,
shafin-deriv,
likhith-deriv and
dan-deriv
as code owners
November 19, 2024 08:15
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
akmal-deriv
had a problem deploying
to
Preview
November 19, 2024 08:15
— with
GitHub Actions
Failure
A production App ID was automatically generated for this PR. (log)
Click here to copy & paste above information.
|
🚨 Lighthouse report for the changes in this PR:
Lighthouse ran with https://deriv-app-git-fork-akmal-deriv-f-snackbar-fix.binary.sx/ |
akmal-deriv
had a problem deploying
to
Preview
November 19, 2024 08:42
— with
GitHub Actions
Failure
kate-deriv
approved these changes
Nov 20, 2024
nijil-deriv
previously approved these changes
Nov 21, 2024
dan-deriv
previously approved these changes
Nov 22, 2024
vinu-deriv
previously approved these changes
Nov 22, 2024
nijil-deriv
reviewed
Nov 22, 2024
akmal-deriv
dismissed stale reviews from vinu-deriv and dan-deriv
via
November 22, 2024 10:22
80f0cf3
kate-deriv
approved these changes
Nov 25, 2024
vinu-deriv
approved these changes
Nov 25, 2024
wojciech-deriv
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
This feature re-triggers barrier validation to ensure any hidden error messages are displayed, even if they were obscured by the action sheet.
This feature enhances error handling by ensuring barrier validation messages are always visible to the user.