Update dependencies to support alternative fs and fix tests in windows. #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to version that supports alternative fs implementations.
4 tasks
- for forked version that supports alternative fs.
dazinator
changed the title
This was referenced Mar 15, 2019
Closed
Closed
dazinator
added a commit
to dazinator/node-filing-cabinet
that referenced
this pull request
Mar 18, 2019
- This won't pass until dependents/node-module-lookup-amd#26 is merged and node-module-lookup dep is updated
|
@mrjoelkemp think this one is ready now. |
mrjoelkemp
reviewed
Mar 19, 2019
| @@ -31,8 +31,8 @@ | |||
| "dependencies": { | |||
| "commander": "^2.8.1", | |||
| "debug": "^4.1.0", | |||
| "file-exists": "^5.0.1", | |||
| "find": "^0.2.8", | |||
| "file-exists-dazinatorfork": "^1.0.2", | |||
There was a problem hiding this comment.
Is the code for this on github? Mind linking to it?
There was a problem hiding this comment.
|
Nice work here. Pushed a new minor release. Thanks for contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
file-existsdependency, to accept fileSystem option (original author of file-exists dependency was unresponsive, so this PR switches to my fork of that (MIT licence in play) with the necessary minor tweak necessary.finddependency, to accept fileSystem option.