Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alternative fs to be specified in options and used for fs interactions #21

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

dazinator
Copy link
Contributor

@dazinator dazinator commented Dec 10, 2018

This is not yet ready to be merged, just opening whilst WIP.

Closes #20

@mrjoelkemp
Copy link
Collaborator

@dazinator wow. This is getting pretty involved no? You're a champ for pushing through the layers here.

- Pass through to require-js-config (and updated dependency version)
- Pass through to file-exists (dependency version yet to be updated)
dependents#20
@dazinator
Copy link
Contributor Author

Yeah.. it is getting a little involved.. I'm still worried it might all be for nothing but we shall see, I haven;t heard anything from the file-exists author yet, I'll give it a few more weeks, but if there are dependencies that are no longer actively maintained, then that's the worry from my side as I wont be able to push things through.

@dazinator
Copy link
Contributor Author

rebased on master.

@mrjoelkemp mrjoelkemp merged commit 0b6e1ca into dependents:master Dec 16, 2018
@mrjoelkemp
Copy link
Collaborator

Looked good to merge. Released a new minor version with doc changes. Thanks for contributing @dazinator.

@dazinator
Copy link
Contributor Author

No problem, thanks for merging. There are still a couple of dependencies to update to nake this work fully though i.e the two unchecked ticked boxes in the pr description. I'll submit another Pr for those changes (basically bumping dep versions) when they are ready ;-)

@dazinator
Copy link
Contributor Author

Once a new build of 'find' dependency is available: https://travis-ci.org/yuanchuan/find/builds
I'll submit a PR that bumps to this dependency to the new version and uses the new API that allows alternative 'fs' to be passed.

I haven't heard anything regarding this PR yet: scottcorgan/file-exists#15 so worst case scenario is that I'd have to create my own fork of file-exists if that repo has gone stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow alternative fs to be used for reading files
2 participants