Skip to content

Try fix CI#6420

Closed
deivid-rodriguez wants to merge 1 commit intomainfrom
try-fix-ci
Closed

Try fix CI#6420
deivid-rodriguez wants to merge 1 commit intomainfrom
try-fix-ci

Conversation

@deivid-rodriguez
Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez commented Jan 12, 2023

No description provided.

@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner January 12, 2023 19:37
@jakecoffman
Copy link
Copy Markdown
Member

jakecoffman commented Jan 12, 2023

I'm guessing #6418 only appeared to pass because it skipped all the builds? 🤦

jakecoffman
jakecoffman reviewed Jan 12, 2023
View reviewed changes
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023

I rebased this on top of #5625 just to see if that fixes anything.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023

Oh, I thought that invalid path was generated by the script and that the issue was more complicated. I saw now that there was just a typo in the path with that duplicated component? (@jakecoffman I think I ate your previous review comment through a force-push, sorry 😳).

@jakecoffman
Copy link
Copy Markdown
Member

jakecoffman commented Jan 12, 2023

No problem, trying a fix over here: #6421

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023

I think we are using the same fix :)

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023

It seems to be building fine now 👍.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023

I removed the commit I had cherry-picked for forcing a rebuild for Python. So should be ready now!

@jakecoffman
Copy link
Copy Markdown
Member

jakecoffman commented Jan 12, 2023

I bumped common to get all the CI to run in #6421 and now seeing what looks like linter errors, so maybe we revert #6421 instead so I can get this fixed?

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 12, 2023 •
edited
Loading

Yeah, that makes sense, better to not introduce more fixups if we're going to need to revert everything 😅. Those linter errors again remind me of how I got into #5625, so I will have a closer look at this!

@deivid-rodriguez deivid-rodriguez marked this pull request as draft January 12, 2023 20:31
@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 13, 2023

All sorted out now. There's some cleanup in this PR that we can still introduce. I'll rebase it next week.

@deivid-rodriguez
Copy link
Copy Markdown
Contributor Author

deivid-rodriguez commented Jan 18, 2023

Actually I prefer to do ☝️ as a separate PR. Closing.

@deivid-rodriguez deivid-rodriguez deleted the try-fix-ci branch January 18, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakecoffman jakecoffman jakecoffman left review comments

Copilot code review Copilot Awaiting requested review from Copilot Copilot will automatically review once the pull request is marked ready for review

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deivid-rodriguez @jakecoffman