Skip to content

remove Dockerfile.ci as it is redundant#6418

Merged
jakecoffman merged 2 commits intomainfrom
jakecoffman/remove-ci-container
Jan 12, 2023
Merged

remove Dockerfile.ci as it is redundant#6418
jakecoffman merged 2 commits intomainfrom
jakecoffman/remove-ci-container

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

@jakecoffman jakecoffman commented Jan 12, 2023

Dockerfile.updater does the same work as Dockerfile.ci to copy source into the container. The benefit of this change is we have one less Dockerfile to think about!

@jakecoffman jakecoffman changed the title the CI image is redundant as the updater does the same copies remove Dockerfile.ci as it is redundant Jan 12, 2023
@jakecoffman jakecoffman marked this pull request as ready for review January 12, 2023 15:39
@jakecoffman jakecoffman requested a review from a team as a code owner January 12, 2023 15:39
Copy link
Copy Markdown
Contributor

@honeyankit honeyankit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less code is better :-)

Copy link
Copy Markdown
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

Copy link
Copy Markdown
Contributor

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@jakecoffman jakecoffman merged commit 79ac123 into main Jan 12, 2023
@jakecoffman jakecoffman deleted the jakecoffman/remove-ci-container branch January 12, 2023 15:50
This was referenced Jan 12, 2023
jakecoffman added a commit that referenced this pull request Jan 12, 2023
jakecoffman added a commit that referenced this pull request Jan 12, 2023
alcere pushed a commit that referenced this pull request Feb 20, 2023
alcere pushed a commit that referenced this pull request Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants