Specs for helmfiles with different names#6105
Conversation
The docker updater for helm charts was hardcoded to `"values.yaml"`. But we should support the full range of filenames supported in the file fetcher... for example, in the wild we saw this failing to update `"arc-values.yaml"` because of this hardcoding.
| Dependabot::DependencyFile.new( | ||
| content: helmfile_body, | ||
| name: "values.yaml" | ||
| name: "values.yaml" # TODO not sure if I need to replace the filenames here or if I can override later in a specific test |
There was a problem hiding this comment.
note to self: this fixture seems to be for all the helm chart tests, so will likely need to refactor things a bit... but no need to fully test that the other filename permutations have exhaustive descriptions as that is the kind of thing that will slow down CI over time... just ensure some basic sanity checking to ensure the updater is picking it up, and then rely on the existing tests to verify that the updater is doing the right thing once it picks it up...
| require "dependabot/docker/utils/helpers" | ||
| require "spec_helper" | ||
|
|
||
| RSpec.describe Dependabot::Docker::Utils.likely_helm_chart? do |
There was a problem hiding this comment.
Since this is a static method on the class, not sure that this is the proper way to call it? Writing this was a reminder I really need to spend some time on basic ruby syntax tutorials... 😀
|
👋 This pull request has been marked as stale because it has been open for 2 years with no activity. You can comment on the PR to hold stalebot off for a while, or do nothing. If you do nothing, this pull request will be closed eventually by the stalebot. Please see CONTRIBUTING.md for more policy details. |
jeffwidman
deleted the
add-unit-tests-for-docker-updater-for-helm-charts
branch
1 participant
Unit tests for #6097.
Broke out as a separate PR because I'm still learning the Rspec DSL.