Update helm charts beyond values.yaml#6097
Conversation
|
Need tests for the updater to ensure we're processing this full suite of files that we do in the fetcher: dependabot-core/docker/spec/dependabot/docker/file_fetcher_spec.rb Lines 273 to 286 in 9b2f675 |
bb59f36 to
e58210f
Compare
e58210f to
39dc4b0
Compare
The docker updater for helm charts was hardcoded to `"values.yaml"`. But we should support the full range of filenames supported in the file fetcher... for example, in the wild we saw this failing to update `"arc-values.yaml"` because of this hardcoding.
39dc4b0 to
1156dc1
Compare
|
I broke the unit tests out separately into #6105 so that it's not blocking merging this code... I'm still learning the Rspec DSL, but since this code is behind a feature flag I'd like to get it live sooner so that if there are other bugs/issues I can see them sooner even while I work through the unit tests. Also so that I can continue to test this code w/o being blocked because other maintainers are offline for Veteran's day. |
|
I manually confirmed this is working against the previously failing repo: |
|
This has been deployed. I'll finish up the unit tests shortly in the other PR. |
The docker updater for helm charts was hardcoded to
"values.yaml".But we should support the full range of filenames supported in the file fetcher... for example, in the wild we saw this failing to update
"arc-values.yaml"because of this hardcoding.