Skip to content

Fix syntax error in Actions workflow file#5805

Merged
bdragon merged 1 commit intomainfrom
bdragon/codeql-workflow
Sep 28, 2022
Merged

Fix syntax error in Actions workflow file#5805
bdragon merged 1 commit intomainfrom
bdragon/codeql-workflow

Conversation

@bdragon
Copy link
Copy Markdown
Contributor

@bdragon bdragon commented Sep 28, 2022

Moves the if condition to the job.

@bdragon bdragon requested a review from a team as a code owner September 28, 2022 17:54
@bdragon bdragon merged commit fcd80c8 into main Sep 28, 2022
@bdragon bdragon deleted the bdragon/codeql-workflow branch September 28, 2022 18:26
Copy link
Copy Markdown
Member

@jeffwidman jeffwidman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Curious btw, is there any way to test these? I couldn't figure out how to test it locally when I originally put up #5784 ... I guess I could have done it on my local repo using a much shorter cron period temporarily in my draft PR to see what got triggered...

@bdragon
Copy link
Copy Markdown
Contributor Author

bdragon commented Sep 29, 2022

I'm not sure if we have something more official but you could lint it using a JSON Schema validator and this schema.

@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants