Merged
Conversation
mctofu
approved these changes
Sep 23, 2022
We run CI via actions on `main` on a daily cron to catch any unexpected regressions, or if CodeQL adds a new check that suddenly flags something. However, this can result in some unexpected notification noise: 1. I merged a PR from an external contributor: #5580 2. That PR was opened from the fork's `main` branch 3. Before merging, I clicked the "Update by rebase". So a commit from me landed on the fork's `main` branch. 4. I'm now receiving daily emails about failing CI runs from the fork. These are pure noise, since I don't care about the state of an external contributor's forked repo. This hasn't happened for any other PR's that I've merged from external contributors, so I suspect it's related to the rebase so I'm now seen as a committer to the fork's `main` branch. Not really sure though. I double-checked and I am _not_ subscribed to notifications on the repo. I am aware that after 30 days this should age out because actions are disabled for forks after 30 days assuming the external contributor doesn't update his fork/click re-enable actions, but it's still annoying. I checked internally with the Actions team, and they said this is known behavior, and it's complicated. So for now, let's default to disabling running cron for forks.
jeffwidman
force-pushed
the
disable-codeql-cron-on-forks
branch
from
982a484 to
78a6c21
Compare
Member
Author
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We run CI via actions on
mainon a daily cron to catch any unexpected regressions, or if CodeQL adds a new check that suddenly flags something.However, this can result in some unexpected notification noise:
mainbranchmainbranch.This hasn't happened for any other PR's that I've merged from external contributors, so I suspect it's related to the rebase so I'm now seen as a committer to the fork's
mainbranch. Not really sure though.I double-checked and I am not subscribed to notifications on the repo. I am aware that after 30 days this should age out because actions are disabled for forks after 30 days assuming the external contributor doesn't update his fork/click re-enable actions, but it's still annoying.
I checked internally with the Actions team, and they said this is known behavior, and it's complicated.
So for now, let's default to disabling running cron for forks.