Skip to content

[npm] Only shortcut search when non-vuln version of advisory dep is found #5796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mctofu merged 1 commit into from
Sep 27, 2022
Merged

[npm] Only shortcut search when non-vuln version of advisory dep is found #5796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions npm_and_yarn/helpers/lib/npm/vulnerability-auditor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,11 +192,12 @@ function buildDependencyChains(auditReport, name) {
}
if (auditReport.has(node.name)) {
const vuln = auditReport.get(node.name)
if (!vuln.isVulnerable(node)) {
// This is a non-vulnerable version of the dependency; end path.
if (vuln.isVulnerable(node)) {
return [{ fixAvailable: vuln.fixAvailable, nodes: [node, ...chain.nodes] }]
} else if (node.name == name) {
// This is a non-vulnerable version of the advisory dependency; end path.
return []
}
return [{ fixAvailable: vuln.fixAvailable, nodes: [node, ...chain.nodes] }]
}
if (!node.edgesOut.size) {
// This is a leaf node that is unaffected by the vuln; end path.
Expand Down