[npm] Only shortcut search when non-vuln version of advisory dep is found#5796
Merged
[npm] Only shortcut search when non-vuln version of advisory dep is found#5796
Conversation
bdragon
approved these changes
Sep 26, 2022
Contributor
bdragon
left a comment
bdragon
left a comment
There was a problem hiding this comment.
Took me a second to wrap my brain around this, but makes sense 👍
There can be other deps marked as vulnerable that aren't the advisory dep (locking parents) and we can't be sure that a non-vulnerable version of those deps doesn't still have a vulnerable version of the advisory dep as a child.
mctofu
force-pushed
the
mctofu/vuln-shortcut
branch
from
cfd0650 to
4556f50
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There can be other deps marked as vulnerable that aren't the advisory dep (locking parents) and we can't be sure that a non-vulnerable version of those deps doesn't still have a vulnerable version of the advisory dep as a child.
For ex for an advisory on C:
I haven't found real examples of this occurring yet but this is worth fixing since it could lead to PRs that don't fully fix an alert.