Skip to content

fix tagged push overwriting previous tags #5649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakecoffman merged 3 commits into from
Sep 8, 2022
Merged

fix tagged push overwriting previous tags #5649

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
25aba14
fix tagged push overwriting previous tags
jakecoffman Sep 7, 2022
bb07310
Merge branch 'main' into jakecoffman/fix-tag-build
jakecoffman Sep 7, 2022
e88d3e5
Merge branch 'main' into jakecoffman/fix-tag-build
jakecoffman Sep 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions .github/workflows/docker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
push-core-image:
name: Push dependabot-core image to docker hub
runs-on: ubuntu-latest
if: ${{ github.repository == 'dependabot/dependabot-core' }}
if: github.repository == 'dependabot/dependabot-core'
permissions:
contents: read
packages: write
Expand Down Expand Up @@ -44,17 +44,17 @@ jobs:
docker tag "$CORE_IMAGE:latest" "$CORE_IMAGE_MIRROR:latest"
docker push "$CORE_IMAGE_MIRROR:latest"
- name: Push tagged image
if: "contains(github.ref, 'refs/tags')"
if: contains(github.ref, 'refs/tags')
run: |
VERSION="$(grep -Eo "[0-9]+\.[0-9]+\.[0-9]+" common/lib/dependabot/version.rb)"
docker tag "$CORE_IMAGE:latest" "$CORE_IMAGE:$VERSION"
docker push "$CORE_IMAGE:$VERSION"
docker tag "$CORE_IMAGE:latest" "$CORE_IMAGE_MIRROR:$VERSION"
docker push "$CORE_IMAGE_MIRROR:$VERSION"
push-updater-image:
name: Push dependabot-updater image to docker hub
name: Push tagged dependabot-updater image
runs-on: ubuntu-latest
if: ${{ github.repository == 'dependabot/dependabot-core' }}
if: contains(github.ref, 'refs/tags')
needs: push-core-image
permissions:
contents: read
Expand All @@ -75,19 +75,10 @@ jobs:
--build-arg OMNIBUS_VERSION=$VERSION \
-f Dockerfile.updater \
.
- name: Log in to the Docker registry
run: |
echo "${{ secrets.DOCKER_PASSWORD }}" | docker login -u ${{ secrets.DOCKER_USERNAME }} --password-stdin
- name: Log in to GHCR
run: |
echo "${{ secrets.GITHUB_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
- name: Push latest image
run: |
docker push "$UPDATER_IMAGE:latest"
docker tag "$UPDATER_IMAGE:latest" "$UPDATER_IMAGE_MIRROR:latest"
docker push "$UPDATER_IMAGE_MIRROR:latest"
- name: Push tagged image
if: "contains(github.ref, 'refs/tags')"
run: |
VERSION="$(grep -Eo "[0-9]+\.[0-9]+\.[0-9]+" common/lib/dependabot/version.rb)"
docker tag "$UPDATER_IMAGE:latest" "$UPDATER_IMAGE:$VERSION"
Expand Down Expand Up @@ -124,7 +115,7 @@ jobs:
run: |
docker push "$DEV_IMAGE:latest"
- name: Push tagged image
if: "contains(github.ref, 'refs/tags')"
if: contains(github.ref, 'refs/tags')
run: |
VERSION="$(grep -Eo "[0-9]+\.[0-9]+\.[0-9]+" common/lib/dependabot/version.rb)"
docker tag "$DEV_IMAGE:latest" "$DEV_IMAGE:$VERSION"
Expand Down