Skip to content

fix tagged push overwriting previous tags#5649

Merged
jakecoffman merged 3 commits intomainfrom
jakecoffman/fix-tag-build
Sep 8, 2022
Merged

fix tagged push overwriting previous tags#5649
jakecoffman merged 3 commits intomainfrom
jakecoffman/fix-tag-build

Conversation

@jakecoffman
Copy link
Copy Markdown
Member

@jakecoffman jakecoffman commented Sep 7, 2022

I noticed that in GHCR we're tagging the latest tagged version 0.212.0 repeatedly, I think this is because this if statement is a string:

if: "contains(github.ref, 'refs/tags')"

I also changed the updater push to not push latest since that's being done in docker-branch-releases.yml now. I moved the if statement up on that job so it only runs to tag if the version changes.

@jakecoffman jakecoffman requested a review from a team as a code owner September 7, 2022 15:16
Copy link
Copy Markdown
Member

@Nishnha Nishnha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct to me

@jakecoffman jakecoffman merged commit b1f69fb into main Sep 8, 2022
@jakecoffman jakecoffman deleted the jakecoffman/fix-tag-build branch September 8, 2022 12:39
@pavera pavera mentioned this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants