Skip to content

Document why the link needs to be unescaped #5186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nishnha merged 2 commits into from
May 24, 2022
Merged

Document why the link needs to be unescaped #5186

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c36aec5
Document why the link needs to be unescaped
jeffwidman May 24, 2022
3a66a72
Rubocop fix trailing whitespace
Nishnha May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nuget/lib/dependabot/nuget/update_checker/version_finder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ def fetch_paginated_v2_nuget_listings(url_details, results = {})

if (link_href = fetch_v2_next_link_href(response.body))
url_details = url_details.dup
# Some Nuget repositories, such as JFrog's Artifactory, URL encode the "next" href
# link in the paged results. If the href is not URL decoded, the paging parameters
# are ignored and the first page is always returned.
url_details[:versions_url] = CGI.unescape(link_href)
fetch_paginated_v2_nuget_listings(url_details, results)
end
Expand Down