Document why the link needs to be unescaped#5186
Merged
Conversation
Since this link will always work on GitHub regardless of whether escaped or not, I added an inline code comment with the commit message from 62366e4. That way someone doesn't accidentally pull this out and think they're okay just because everything continues to work on GitHub.
Nishnha
approved these changes
May 24, 2022
jeffwidman
commented
May 24, 2022
| url_details = url_details.dup | ||
| # Some Nuget repositories, such as JFrog's Artifactory, URL encode the "next" href | ||
| # link in the paged results. If the href is not URL decoded, the paging parameters | ||
| # are ignored and the first page is always returned. |
Member
Author
There was a problem hiding this comment.
Oof! That's what I get for editing directly in the Web UI instead of my editor. Thanks @Nishnha !
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since this link will always work on GitHub regardless of whether escaped or not,
I added an inline code comment with the commit message from 62366e4.
That way someone doesn't accidentally pull this out and think they're okay just
because everything continues to work on GitHub.
I meant to tag this onto #5174 but then forgot before I clicked the merge button.