nuget: fix PR missing commits in message when using private registry#5072
Merged
jakecoffman merged 5 commits intomainfrom May 4, 2022
Merged
nuget: fix PR missing commits in message when using private registry#5072jakecoffman merged 5 commits intomainfrom
jakecoffman merged 5 commits intomainfrom
Conversation
# Conflicts: # nuget/lib/dependabot/nuget/metadata_finder.rb # nuget/spec/dependabot/nuget/metadata_finder_spec.rb
brrygrdn
reviewed
May 4, 2022
Contributor
brrygrdn
left a comment
brrygrdn
left a comment
There was a problem hiding this comment.
One question, otherwise this LGTM
| end | ||
| end | ||
| # failed to find a source URL | ||
| nil |
Contributor
There was a problem hiding this comment.
Should we add a rescue JSON::ParserError to this method or move the rescue up into src_repo_from_project to handle both extract_ methods?
I'm just thinking that while a registry switching from JSON to not-JSON between endpoints would be surprising, it could happen if we hit some kind of error that returned arbitrary content from the remote stack.
Move the error handling around as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reverted #5002 because it introduced some new errors, so this is #5002 plus some additional error handling and tests.
I left in some TODOs to ask the question: should we log? I haven't seen any other log messages in core yet so I wanted to see if we could log at all. If we are eating exceptions and don't log, we are going to spend more time investigating issues that end up to be working as expected.
Ruby style feedback is welcome as well!