nuget: fix PR missing commits in message when using private registry#5002
Merged
jakecoffman merged 9 commits intomainfrom Apr 19, 2022
Merged
nuget: fix PR missing commits in message when using private registry#5002jakecoffman merged 9 commits intomainfrom
jakecoffman merged 9 commits intomainfrom
Conversation
mctofu
reviewed
Apr 14, 2022
Contributor
mctofu
left a comment
There was a problem hiding this comment.
This approach makes sense to me! Thanks for the detailed explanation!
Agree that it's best to avoid downloading the .nupkg.
Member
Author
|
@dependabot/reviewers This is ready for review now. |
brrygrdn
reviewed
Apr 19, 2022
brrygrdn
approved these changes
Apr 19, 2022
Contributor
brrygrdn
left a comment
There was a problem hiding this comment.
👍🏻 I like this approach, ![]()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Dependabot PRs are missing the release notes and commits sections that we expect them to have when using a private NuGet registry like nuget.pkg.github.com.
This is because the GitHub NuGet registry doesn't support downloading
.nuspecfiles currently, and this is the way we're finding the source repo of the project.The
.nuspecURL is part of the NuGet Server spec.A solution
This PR adds a fallback to try to find the
projectUrlorlicenseUrlin the search data, which might contain the repo. The search URL is supported by GitHub Packages and the official NuGet server.This will require users to enter a repo URL in the
projectUrl, instead of therepositoryUrlfield, sincerepositoryUrlisn't exposed in the search endpoint. The only way to get to thatrepositoryUrlseems to be in that.nuspecfile.Another possible solution is downloading the
.nupkgand extracting the.nuspec, but I think that could have an effect on billing and that is probably undesirable. Also there's a risk the.nupkgis quite large since it contains binaries.We could also ask GitHub Packages to implement that endpoint, this PR is meant as a stopgap or fallback when the
nuspecis not available.No tests yet: Wanted to get buy-in from the approach here.