validate shape of packages.config and consolidate error handling
#11303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Jan 14, 2025
| var invalidPackageElements = Packages.Where(p => p.GetAttribute("id") is null || p.GetAttribute("version") is null).ToList(); | ||
| if (invalidPackageElements.Any()) | ||
| { | ||
| throw new UnparseableFileException("`package` element missing `id` or `version` attributes", path); |
There was a problem hiding this comment.
This was the fix for the linked issue.
brettfo
commented
Jan 14, 2025
| @@ -14,4 +19,23 @@ public JobErrorBase(string type) | |||
|
|
|||
| [JsonPropertyName("error-details")] | |||
| public Dictionary<string, object> Details { get; init; } = new(); | |||
|
|
|||
| public static JobErrorBase ErrorFromException(Exception ex, string jobId, string currentDirectory) | |||
There was a problem hiding this comment.
This is the consolidated error conversion.
brettfo
force-pushed
the
dev/brettfo/nuget-packages-config-parse
branch
3 times, most recently
from
1950ee9 to
8667468
Compare
sebasgomez238
approved these changes
Jan 15, 2025
brettfo
force-pushed
the
dev/brettfo/nuget-packages-config-parse
branch
from
8667468 to
692d989
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate the shape of
packages.configwhen first opening the fileFixes #11250.
During this I realized that we had way too many ways to represent errors and to convert them, so everything was consolidated into a single function
JobErrorBase.ErrorFromException(). Everything else is just calling this helper and updating the tests.