Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NuGet updater missing chance to return DependencyFileNotParseable #11250

Closed
brettfo opened this issue Jan 8, 2025 · 0 comments · Fixed by #11303
Closed

NuGet updater missing chance to return DependencyFileNotParseable #11250

brettfo opened this issue Jan 8, 2025 · 0 comments · Fixed by #11303
Assignees
@brettfo
Labels
L: dotnet:nuget NuGet packages via nuget or dotnet

Comments

@brettfo
Copy link
Contributor

brettfo commented Jan 8, 2025 •
edited
Loading

Seen in the logs, if a packages.config file uses an upper-case attribute name (e.g., Version="1.2.3" instead of the expected version="1.2.3"), NuGet can't handle this. We should check this early on and report DependencyFileNotParseable. Issue appears in the log as

An error occurred while reading file '/home/dependabot/dependabot-updater/repo/path/to/packages.config': Invalid package version for package id 'Some.Package': ''

Required attributes are id and version, optional attributes are targetFramework.

Error should be reported during discovery.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brettfo brettfo

Labels
L: dotnet:nuget NuGet packages via nuget or dotnet
Projects
Dependabot
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validate shape of packages.config and consolidate error handling dependabot/dependabot-core
1 participant
@brettfo