Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug related to empty package manager name in npm_and_yarn package manager #10936

Merged
merged 2 commits into from
Nov 14, 2024
+3 −1
Merged

Fix bug related to empty package manager name in npm_and_yarn package manager #10936

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9639027
fix the bug related to empty package manager name
kbukum1 Nov 14, 2024
cc2efa7
Merge branch 'main' into kamil/fix_bug_related_to_empty_package_manag…
kbukum1 Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion npm_and_yarn/lib/dependabot/npm_and_yarn/package_manager.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,10 @@ def setup(name)

private

sig { params(name: String).returns(Ecosystem::VersionManager) }
sig { params(name: T.nilable(String)).returns(Ecosystem::VersionManager) }
def package_manager_by_name(name)
name = DEFAULT_PACKAGE_MANAGER if name.nil? || PACKAGE_MANAGER_CLASSES[name].nil?

package_manager_class = PACKAGE_MANAGER_CLASSES[name]

package_manager_class ||= PACKAGE_MANAGER_CLASSES[DEFAULT_PACKAGE_MANAGER]
Expand Down
Loading