Fix bug related to empty package manager name in npm_and_yarn package manager #10936
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
This PR fixes a bug in the
npm_and_yarn/package_manager.rb
file where an empty or undefined package manager name resulted in aNoMethodError
(undefined method 'to_sym' for an instance of Hash
). This error, as reported in Sentry Issue DELTAFORCE-11XD, occurred whenpackage_manager_by_name
was called with an invalid package manager name.The update ensures that the method handles cases of empty or invalid package manager names gracefully, preventing
to_sym
from being called on unintended data types.Anything you want to highlight for special attention from reviewers?
To resolve this issue, the code now checks the validity of the package manager name before calling
to_sym
. Reviewers should focus on the additional validation logic to confirm that it aligns with expected behavior for handling empty or missing package manager names.How will you know you've accomplished your goal?
Checklist