Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot changed GitHub https dependency to ssh, breaking pnpm install #7851

Closed
1 task done
advaith1 opened this issue Aug 20, 2023 · 2 comments · Fixed by #11465
Closed
1 task done

Dependabot changed GitHub https dependency to ssh, breaking pnpm install #7851

advaith1 opened this issue Aug 20, 2023 · 2 comments · Fixed by #11465
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working

Comments

@advaith1
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Package ecosystem

npm

Package manager version

pnpm 8.6.12

Language version

Node.js v20.5.1

Manifest location and content before the Dependabot update

pnpm-lock.yaml https://gist.github.com/advaith1/0e6ea682f1169e6062260fe02a965dd3

dependabot.yml content

I did not enable or configure Dependabot.

Updated dependency

github:advaith1/Spark#main, commit hash did not change

What you expected to see, versus what you actually saw

I did not enable Dependabot, but GitHub automatically enabled it on my repo and it created some PRs. All of these PRs modified an unrelated GitHub dependency from https to ssh, which broke installing, both locally and in CI.

image

This seems to be the opposite issue as #5071

Native package manager behavior

To fix the issue, I ran pnpm i github:advaith1/Spark#main, which reverted the change and converted the dependency back to https.

Images of the diff or a link to the PR, issue, or logs

The problematic Dependabot change in all 4 PRs:
image

The dependency updates Dependabot was doing:
image

Smallest manifest that reproduces the issue

No response

@kylebenji
Copy link

Also seeing this issue. It entirely breaks all vercel previews for Dependabot PRs since pnpm install is now failing for all of them.

dependancy is also a "github/" dependancy exactly as above and dependabot is converting the version field in pnpm-lock from "github/<...rest of version>" to "[email protected]+<...rest of version>".

@TonyRL
Copy link

TonyRL commented Apr 22, 2024

Looks like a duplicate of #7258. See pnpm/pnpm#6050 and pnpm/pnpm#6530 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: javascript:pnpm npm packages via pnpm T: bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants