Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(yaml): add KindType generic type argument to Type #5461

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Jul 17, 2024

I'm mostly certain this is the right approach.

Supercedes #5453

@iuioiua iuioiua requested a review from kt3k as a code owner July 17, 2024 01:42
@github-actions github-actions bot added the yaml label Jul 17, 2024
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.35%. Comparing base (df388b1) to head (774d327).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5461   +/-   ##
=======================================
  Coverage   96.35%   96.35%           
=======================================
  Files         461      463    +2     
  Lines       37762    37731   -31     
  Branches     5576     5571    -5     
=======================================
- Hits        36385    36357   -28     
+ Misses       1335     1332    -3     
  Partials       42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 8b8333f into main Jul 17, 2024
17 checks passed
@iuioiua iuioiua deleted the yaml-Type-scalar branch July 17, 2024 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants