Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(yaml): define ScalarType type and use it for implicit types #5453

Closed
wants to merge 1 commit into from
Closed

refactor(yaml): define ScalarType type and use it for implicit types #5453

wants to merge 1 commit into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jul 16, 2024

We removed the check of non-scalar types in implicit list of schema in #5445

This PR checks that constraint by defining ScalarType type and only allowing it for implicit types of the schemas.

@github-actions github-actions bot added the yaml label Jul 16, 2024
@iuioiua
Copy link
Contributor

iuioiua commented Jul 16, 2024 •
edited
Loading

What about adding a type argument to Type instead? That's what I was going to do after #5445.

@kt3k
Copy link
Member Author

kt3k commented Jul 16, 2024

Can you create a PR?

@iuioiua iuioiua mentioned this pull request Jul 17, 2024
Merged
@kt3k kt3k closed this Jul 17, 2024
@kt3k kt3k deleted the refactor-yaml-scalar-type branch November 20, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kt3k @iuioiua