Consider removing derive_more dependency for serde_v8 #640
Comments
|
Hey @svix-jplatte, thanks for spotting this. We will definitely accept a PR that removes |
mmastrac
pushed a commit
that referenced
this issue
Mar 8, 2024
I found some of the generated impls like [this one](https://docs.rs/serde_v8/latest/serde_v8/struct.BigInt.html#impl-AsMut%3C__AsMutT%3E-for-BigInt) quite weird so I removed or replaced them with different ones, as seemed reasonable in the specific cases. Let me know what you think. The individual commit messages have more details on why I chose certain replacements. Closes #640.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This dependency is only used to derive trivial
Deref,DerefMut,AsRefandAsMutimplementations. However, it requires 3.3s to compile on my machine and much more if you count all its dependencies.Would you accept a PR that replaces these derives with hand-written (or
macro_rules!-produced) implementations?Related: denoland/rust-urlpattern#47
The text was updated successfully, but these errors were encountered: