Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace derive_more #47

Closed
svix-jplatte opened this issue Mar 6, 2024 · 2 comments · Fixed by #48
Closed

Replace derive_more #47

svix-jplatte opened this issue Mar 6, 2024 · 2 comments · Fixed by #48

Comments

@svix-jplatte
Copy link

svix-jplatte commented Mar 6, 2024

Hey, I see that derive_more is only used in two modules to derive Display. With many proc-macros having moved to syn 2.0 but derive_more not (outside of beta releases), plus being somewhat heavy itself (containing much more than just that Display derive, taking 3.3s to compile on my machine compared to syn's 6s), I think this dependency is a rather big compile time hit for the relatively small value it provides.

Would you accept a PR that replaced all four derived Display implementations with hand-written ones? Alternatively, would you accept a PR that replaced the three Display derives (and two missing Error impls) in error.rs with thiserror::Error derives, and the last Display derive with a manual implementation?

@bartlomieju
Copy link
Member

Hey @svix-jplatte, thanks for spotting this. We will definitely accept a PR that removes derive_more in favor of using a hand rolled solution.

@svix-jplatte
Copy link
Author

PR is up ^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants