You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey, I see that derive_more is only used in two modules to derive Display. With many proc-macros having moved to syn 2.0 but derive_more not (outside of beta releases), plus being somewhat heavy itself (containing much more than just that Display derive, taking 3.3s to compile on my machine compared to syn's 6s), I think this dependency is a rather big compile time hit for the relatively small value it provides.
Would you accept a PR that replaced all four derived Display implementations with hand-written ones? Alternatively, would you accept a PR that replaced the three Display derives (and two missing Error impls) in error.rs with thiserror::Error derives, and the last Display derive with a manual implementation?
The text was updated successfully, but these errors were encountered:
Hey, I see that
derive_more
is only used in two modules to deriveDisplay
. With many proc-macros having moved tosyn 2.0
butderive_more
not (outside of beta releases), plus being somewhat heavy itself (containing much more than just thatDisplay
derive, taking 3.3s to compile on my machine compared to syn's 6s), I think this dependency is a rather big compile time hit for the relatively small value it provides.Would you accept a PR that replaced all four derived
Display
implementations with hand-written ones? Alternatively, would you accept a PR that replaced the threeDisplay
derives (and two missingError
impls) inerror.rs
withthiserror::Error
derives, and the lastDisplay
derive with a manual implementation?The text was updated successfully, but these errors were encountered: