-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade: Tokio 0.2 #3418
upgrade: Tokio 0.2 #3418
Conversation
45a7604
to
f02028f
Compare
FYI: I hit some problems upgrading |
022dd6a
to
0563f54
Compare
cbf18eb
to
8053e35
Compare
reqwest is close to 0.10.0 release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much for working on this! Please add TODOs and/or an issue describing the flush situation. It's not ideal - but I think we all agree that this needs to land. Otherwise LGTM.
Did this add native-tls as a requirement (in hyper?). It seems like openssl is now required (at least to build) on Amazon Linux, where previously we were using rustls? In the docs: https://hyper.rs/guides/client/configuration/
But I'm not really sure how! |
This PR upgrades Tokio version in CLI.
There are currently two pending issues:
new(fixed in Tokio 0.2.2)tokio::fs::File
doesn't expose.into_std()
method, which means file cannot be passed to subprocess as stdioreqwest
update, ie.fetch
API doesn't work yetRef #3387, tokio-rs/tokio#1852