Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor cli/http_body.rs to cli/ops/fetch.rs #3566

Closed
bartlomieju opened this issue Dec 30, 2019 · 0 comments · Fixed by #3569
Closed

refactor cli/http_body.rs to cli/ops/fetch.rs #3566

bartlomieju opened this issue Dec 30, 2019 · 0 comments · Fixed by #3569

Comments

@bartlomieju
Copy link
Member

cli/http_body.rs contains HttpBody struct which wraps body of reqwest response to work as Deno resource. It is only used in fetch op and all of the contents should be moved to cli/ops/fetch.rs

Additionally the logic of HttpBody can be simplified:
#3418 (comment)

Example implementation done by @95th:
https://github.com/denoland/deno/pull/3544/files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: move HttpBody to cli/http_util.rs bartlomieju/deno
1 participant
@bartlomieju