feat(bundle, unstable): bundling backed by esbuild#29470
feat(bundle, unstable): bundling backed by esbuild#29470nathanwhit merged 50 commits intodenoland:mainfrom
Conversation
nathanwhit
changed the title
nathanwhit
force-pushed
the
deno-bundle-esbuild
branch
from
64cffeb to
da21da5
Compare
|
|
||
| { | ||
| tokio::spawn(async move { | ||
| let res = esbuild.wait_for_exit().await; |
There was a problem hiding this comment.
Is it ok to have this in a tokio task? If Deno errors, will it kill the esbuild process?
| let pin = pin.await?; | ||
| Ok(Some((pin.code.as_bytes().to_vec(), loader))) | ||
| } | ||
| } |
There was a problem hiding this comment.
Hmmm... might be nice if we figured out how to remove deno_core from here.
There was a problem hiding this comment.
IMO this is fine since we use deno_core::ModuleLoader here
bartlomieju
left a comment
bartlomieju
left a comment
There was a problem hiding this comment.
Let's land and keep iterating
| deno bundle https://deno.land/std/examples/colors.ts colors.bundle.js | ||
|
|
||
| If no output file is given, the output is written to standard output: | ||
|
|
||
| deno bundle https://deno.land/std/examples/colors.ts |
There was a problem hiding this comment.
Let's improve this in a follow up - it's probably better to give examples of bundling code on disk than an http specifier
|
|
||
| { | ||
| tokio::spawn(async move { | ||
| let res = esbuild.wait_for_exit().await; |
There was a problem hiding this comment.
Did you verify it after all?
| let pin = pin.await?; | ||
| Ok(Some((pin.code.as_bytes().to_vec(), loader))) | ||
| } | ||
| } |
There was a problem hiding this comment.
IMO this is fine since we use deno_core::ModuleLoader here
|
super excited about this PR! |
4 participants
todo:
--external)esbuild_rsto thedenolandorg