fix(node/tty): fix tty.WriteStream.hasColor with different args (#2…

…5094) The check in `tty.WriteStream.prototype.hasColors()` was incorrect leading to the [`yoctocolors`](https://github.com/sindresorhus/yoctocolors) package not printing any colors. Fixes #24407
denoland · Aug 19, 2024 · 48701c1 · 48701c1
1 parent c94c5cd
commit 48701c1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/ext/node/polyfills/tty.js b/ext/node/polyfills/tty.js
@@ -113,7 +113,10 @@ export class WriteStream extends Socket {
    * @returns {boolean}
    */
   hasColors(count, env) {
-    if (env === undefined && typeof count === "object") {
+    if (
+      env === undefined &&
+      (count === undefined || typeof count === "object" && count !== null)
+    ) {
       env = count;
       count = 16;
     }

diff --git a/tests/unit_node/tty_test.ts b/tests/unit_node/tty_test.ts
@@ -38,6 +38,10 @@ Deno.test("[node/tty WriteStream.isTTY] returns true when fd is a tty", () => {
 
 Deno.test("[node/tty WriteStream.hasColors] returns true when colors are supported", () => {
   assert(tty.WriteStream.prototype.hasColors() === !Deno.noColor);
+  assert(tty.WriteStream.prototype.hasColors({}) === !Deno.noColor);
+
+  assert(tty.WriteStream.prototype.hasColors(1));
+  assert(tty.WriteStream.prototype.hasColors(1, {}));
 });
 
 Deno.test("[node/tty WriteStream.getColorDepth] returns current terminal color depth", () => {