Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node:tty #24407

Closed
bombillazo opened this issue Jul 3, 2024 · 1 comment · Fixed by #25094
Closed

Support node:tty #24407

bombillazo opened this issue Jul 3, 2024 · 1 comment · Fixed by #25094
Labels
bug Something isn't working correctly node API Related to various "node:*" modules APIs node compat

Comments

@bombillazo
Copy link

Some libraries such as chalk, yoctocolors and other terminal related libraries use the TTY libraries for different terminal functionalities. According to the deno compatibility list, node:tty is missing both the WriteStream and ReadStream implementations.
@bartlomieju bartlomieju added bug Something isn't working correctly node compat node API Related to various "node:*" modules APIs labels Jul 3, 2024
@bombillazo
Copy link
Author

Seems like there is a PR already in the works

@bombillazo bombillazo mentioned this issue Jul 4, 2024
Closed
@marvinhagemeister marvinhagemeister mentioned this issue Aug 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working correctly node API Related to various "node:*" modules APIs node compat
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(node/tty): fix tty.WriteStream.hasColor with different args denoland/deno
2 participants
@bartlomieju @bombillazo