Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add changes to set delimiter for attributes split #29177

Conversation

content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@franciscojavierfernandezjim

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: link to the issue

Description

A few sentences describing the overall goals of the pull request's commits.

Must have

  • Tests
  • Documentation

* add changes to set delimiter for attributes split

* release notes and docker update

* fix issues for circleci

* fix release notes and test

* fix _test

* add positional argument to test

* update docker image

* update release notes

* fix Release Notes and README

* add changes of Ofri
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! pending-demo Demo pending Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR labels Aug 23, 2023
@content-bot content-bot requested a review from ostolero August 23, 2023 15:01
@ostolero ostolero merged commit 32ab480 into master Aug 23, 2023
@ostolero ostolero deleted the contrib/franciscojavierfernandezjim_choose_delimiter_for_publish branch August 23, 2023 21:24
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Oct 5, 2023
…misto#29177)

* add changes to set delimiter for attributes split

* release notes and docker update

* fix issues for circleci

* fix release notes and test

* fix _test

* add positional argument to test

* update docker image

* update release notes

* fix Release Notes and README

* add changes of Ofri

Co-authored-by: franciscojavierfernandezjim <[email protected]>
Co-authored-by: ostolero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR pending-demo Demo pending Xsoar Support Level Indicates that the contribution is for XSOAR supported pack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants