add changes to set delimiter for attributes split #29010
Conversation
content-bot
added
Community
Contribution Form Filled
content-bot
changed the base branch from
master
to
contrib/franciscojavierfernandezjim_choose_delimiter_for_publish
|
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @ostolero will know the proposed changes are ready to be reviewed. |
|
Hi! The PR is ready to verify but i don't know how to pass "Review Release Notes / release_notes_review" check, can u help me? ty |
There was a problem hiding this comment.
Hi @franciscojavierfernandezjim , the changes look great!
I added one minor comment and I think we can go ahead and schedule our demo I'll reach out through slack.
Regarding the pre-commit test it's not mandatory so I think we can ignore it for now.
| @@ -698,6 +698,7 @@ def publish_message_command( | |||
| project_id: str, | |||
| data: str = None, | |||
| attributes: str = None, | |||
| delim_char_attributes: str = None, | |||
There was a problem hiding this comment.
Let's change this to be default ',' if possible. Shouldn't make a difference as the default in yml is ',' but in case that is not the case this None could ovveride the next default in attribute_pairs_to_dict
There was a problem hiding this comment.
Done!
ostolero
merged commit f5118cc
into
demisto:contrib/franciscojavierfernandezjim_choose_delimiter_for_publish
* add changes to set delimiter for attributes split * release notes and docker update * fix issues for circleci * fix release notes and test * fix _test * add positional argument to test * update docker image * update release notes * fix Release Notes and README * add changes of Ofri Co-authored-by: franciscojavierfernandezjim <[email protected]> Co-authored-by: ostolero <[email protected]>
…misto#29177) * add changes to set delimiter for attributes split * release notes and docker update * fix issues for circleci * fix release notes and test * fix _test * add positional argument to test * update docker image * update release notes * fix Release Notes and README * add changes of Ofri Co-authored-by: franciscojavierfernandezjim <[email protected]> Co-authored-by: ostolero <[email protected]>
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
fixes: link to the issue
Description
A few sentences describing the overall goals of the pull request's commits.
Must have