-
Notifications
You must be signed in to change notification settings - Fork 0
Add ReviewMark integration and file review infrastructure #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
75b6561
Initial plan
Copilot 6ab5027
feat: add ReviewMark integration and recent template updates
Copilot cb21558
chore: remove stale note about reviews branch from .reviewmark.yaml
Copilot 9d91641
Potential fix for pull request finding
Malcolmnixon 26ee991
Potential fix for pull request finding
Malcolmnixon 902cd31
chore: remove versionmark from .versionmark.yaml tool capture list
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,6 +45,8 @@ | |
| "Qube", | ||
| "reqstream", | ||
| "ReqStream", | ||
| "reviewmark", | ||
| "ReviewMark", | ||
| "Sarif", | ||
| "SarifMark", | ||
| "SBOM", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| --- | ||
| name: Code Review Agent | ||
| description: Assists in performing formal file reviews - knows how to elaborate review-sets and perform structured review checks | ||
| --- | ||
|
|
||
| # Code Review Agent - VersionMark | ||
|
|
||
| Perform formal file reviews for a named review-set, producing a structured findings report. | ||
|
|
||
| ## When to Invoke This Agent | ||
|
|
||
| Invoke the code-review-agent for: | ||
|
|
||
| - Performing a formal review of a named review-set | ||
| - Producing review evidence for the Continuous Compliance pipeline | ||
| - Checking files against the structured review checklist | ||
|
|
||
| ## How to Run This Agent | ||
|
|
||
| When invoked, the agent will be told which review-set is being reviewed. For example: | ||
|
|
||
| ```text | ||
| Review the "VersionMark-CLI-Review" review-set. | ||
| ``` | ||
|
|
||
| ## Responsibilities | ||
|
|
||
| ### Step 1: Elaborate the Review-Set | ||
|
|
||
| Run the following command to get the list of files in the review-set: | ||
|
|
||
| ```bash | ||
| dotnet reviewmark --elaborate [review-set-id] | ||
| ``` | ||
|
|
||
| For example: | ||
|
|
||
| ```bash | ||
| dotnet reviewmark --elaborate VersionMark-CLI-Review | ||
| ``` | ||
|
|
||
| This will output the list of files covered by the review-set, along with their fingerprints | ||
| and current review status (current, stale, or missing). | ||
|
|
||
| ### Step 2: Review Each File | ||
|
|
||
| For each file in the review-set, apply the checks from the standard review template at | ||
| [review-template.md](https://github.com/demaconsulting/ContinuousCompliance/blob/main/docs/review-template/review-template.md). | ||
| Determine which checklist sections apply based on the type of file (requirements, documentation, | ||
| source code, tests). | ||
|
|
||
| ### Step 3: Generate Report | ||
|
|
||
| Write an `AGENT_REPORT_review-[review-set-id].md` file in the repository root with the | ||
| structured findings. This file is excluded from git and linting via `.gitignore`. | ||
|
|
||
| ## Report Format | ||
|
|
||
| The generated `AGENT_REPORT_review-[review-set-id].md` must include: | ||
|
|
||
| 1. **Review Header**: Project, Review ID, review date, files under review | ||
| 2. **Checklist Results**: Each applicable section with Pass/Fail/N/A for every check | ||
| 3. **Summary of Findings**: Any checks recorded as Fail, and notable observations | ||
| 4. **Overall Outcome**: Pass or Fail with justification | ||
|
|
||
| ## Don't | ||
|
|
||
| - Make any changes to source files, tests, or documentation during a review — record all | ||
| findings in the report only | ||
| - Skip applicable checklist sections | ||
| - Record findings without an overall outcome | ||
| - Commit the `AGENT_REPORT_*.md` file (it is excluded from git via `.gitignore`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| --- | ||
| # ReviewMark Configuration File | ||
| # This file defines which files require review, where the evidence store is located, | ||
| # and how files are grouped into named review-sets. | ||
|
|
||
| # Patterns identifying all files that require review. | ||
| # Processed in order; prefix a pattern with '!' to exclude. | ||
| needs-review: | ||
| - "**/*.cs" | ||
| - "!**/obj/**" | ||
|
|
||
| # Evidence source: review data and index.json are located in the 'reviews' branch | ||
| # of this repository, accessed through the GitHub public HTTPS raw content access. | ||
| evidence-source: | ||
| type: url | ||
| location: https://raw.githubusercontent.com/demaconsulting/VersionMark/reviews/index.json | ||
|
|
||
| # Review sets grouping files by logical unit of review. | ||
| reviews: | ||
| - id: VersionMark-CLI-Review | ||
| title: Review of VersionMark CLI | ||
| paths: | ||
| - "src/**/Program.cs" | ||
| - "src/**/Context.cs" | ||
| - "test/**/ProgramTests.cs" | ||
| - "test/**/ContextTests.cs" | ||
|
|
||
| - id: VersionMark-Utilities-Review | ||
| title: Review of VersionMark Utilities | ||
| paths: | ||
| - "src/**/PathHelpers.cs" | ||
| - "src/**/Validation.cs" | ||
| - "src/**/MarkdownFormatter.cs" | ||
| - "src/**/VersionInfo.cs" | ||
| - "src/**/VersionMarkConfig.cs" | ||
| - "test/**/PathHelpersTests.cs" | ||
| - "test/**/MarkdownFormatterTests.cs" | ||
| - "test/**/VersionInfoTests.cs" | ||
| - "test/**/VersionMarkConfigTests.cs" | ||
|
|
||
| - id: VersionMark-Tests-Review | ||
| title: Review of VersionMark Integration Tests | ||
| paths: | ||
| - "test/**/IntegrationTests.cs" | ||
| - "test/**/Runner.cs" | ||
| - "test/**/AssemblyInfo.cs" | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| resource-path: | ||
| - docs/reviewplan | ||
| - docs/template | ||
| input-files: | ||
| - docs/reviewplan/title.txt | ||
| - docs/reviewplan/introduction.md | ||
| - docs/reviewplan/review-plan.md | ||
| template: template.html | ||
| table-of-contents: true | ||
| number-sections: true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # Introduction | ||
|
|
||
| This document contains the review plan for the VersionMark project. | ||
|
|
||
| ## Purpose | ||
|
|
||
| This review plan provides a comprehensive overview of all files requiring formal review | ||
| in the VersionMark project. It identifies which review-sets cover which files and serves | ||
| as evidence that every file requiring review is covered by at least one named review-set. | ||
|
|
||
| ## Scope | ||
|
|
||
| This review plan covers: | ||
|
|
||
| - C# source code files requiring formal review | ||
| - Mapping of C# source files to named review-sets | ||
|
|
||
| ## Generation Source | ||
|
|
||
| This plan is automatically generated by the ReviewMark tool, analyzing the | ||
| `.reviewmark.yaml` configuration and the review evidence store. It serves as evidence | ||
| that every file requiring review is covered by a current, valid review. | ||
|
|
||
| ## Audience | ||
|
|
||
| This document is intended for: | ||
|
|
||
| - Software developers working on VersionMark | ||
| - Quality assurance teams validating review coverage | ||
| - Project stakeholders reviewing compliance status | ||
| - Auditors verifying that all required files have been reviewed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| --- | ||
| title: VersionMark Review Plan | ||
| subtitle: File Review Plan for VersionMark | ||
| author: DEMA Consulting | ||
| description: File Review Plan for VersionMark | ||
| lang: en-US | ||
| keywords: | ||
| - VersionMark | ||
| - Review Plan | ||
| - File Reviews | ||
| - .NET | ||
| - Tool | ||
| --- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| --- | ||
| resource-path: | ||
| - docs/reviewreport | ||
| - docs/template | ||
| input-files: | ||
| - docs/reviewreport/title.txt | ||
| - docs/reviewreport/introduction.md | ||
| - docs/reviewreport/review-report.md | ||
| template: template.html | ||
| table-of-contents: true | ||
| number-sections: true |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.