Add ReviewMark integration and file review infrastructure#34
Merged
Malcolmnixon merged 6 commits intomainfrom Mar 13, 2026
Merged
Add ReviewMark integration and file review infrastructure#34Malcolmnixon merged 6 commits intomainfrom
Malcolmnixon merged 6 commits intomainfrom
Conversation
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update template with ReviewMark and file reviews
Add ReviewMark integration and file review infrastructure
Mar 13, 2026
Malcolmnixon
requested changes
Mar 13, 2026
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
Malcolmnixon
approved these changes
Mar 13, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Adds ReviewMark-based file review infrastructure to VersionMark (tool registration, review configuration, document templates, CI generation/validation, and agent guidance) to support formal review plan/report generation and traceability.
Changes:
- Registers ReviewMark as a dotnet tool and adds
.reviewmark.yamlreview-set configuration + CI steps to validate and generate review plan/report artifacts. - Extends VersionMark tool-version capture configuration to include ReviewMark (and VersionMark itself) and updates regex patterns.
- Adds ReviewMark plan/report Pandoc/WeasyPrint document scaffolding and links ReviewMark into
requirements.yaml+ agent documentation.
Reviewed changes
Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
.config/dotnet-tools.json |
Adds ReviewMark as a restored local dotnet tool. |
.versionmark.yaml |
Adds versionmark/reviewmark capture entries and updates regexes. |
.reviewmark.yaml |
Introduces review-set definitions and evidence-source configuration. |
.github/workflows/build.yaml |
Runs ReviewMark self-validation; generates/displays plan/report; produces HTML/PDF docs; captures tool versions including ReviewMark. |
docs/reviewplan/* |
Adds Pandoc defaults/title/intro scaffolding for the review plan document. |
docs/reviewreport/* |
Adds Pandoc defaults/title/intro scaffolding for the review report document. |
.gitignore |
Ignores generated review-plan/report markdown outputs. |
requirements.yaml |
Adds an OTS requirement and test IDs for ReviewMark plan/report generation. |
.github/agents/code-review-agent.md |
Adds a structured “Code Review Agent” checklist/process doc. |
AGENTS.md |
Lists “Code Review Agent” and adds selection guidance. |
.cspell.json |
Adds ReviewMark words to the dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Malcolmnixon <1863707+Malcolmnixon@users.noreply.github.com>
This was referenced Mar 30, 2026
This was referenced Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagates TemplateDotNetTool PRs #58 and #59 into VersionMark: introduces ReviewMark tooling, three VersionMark-specific review-sets, review plan/report document generation, and the code-review-agent.
ReviewMark tool registration
.config/dotnet-tools.json— addsdemaconsulting.reviewmarkv0.1.0-rc.3.versionmark.yaml— addsreviewmarkcapture entry; upgrades all tool regexes with(?i)and pre-release suffix pattern(?:-[a-zA-Z0-9.]+)?;versionmarkis intentionally omitted as the build itself determines the versionReview configuration
.reviewmark.yaml(new) — three review-sets scoped to VersionMark's source layout:VersionMark-CLI-Review—Program.cs,Context.cs+ their testsVersionMark-Utilities-Review—PathHelpers.cs,Validation.cs,MarkdownFormatter.cs,VersionInfo.cs,VersionMarkConfig.cs+ their testsVersionMark-Tests-Review—IntegrationTests.cs,Runner.cs,AssemblyInfo.cs.gitignore— excludes generatedreview-plan.mdandreview-report.mdDocument infrastructure
docs/reviewplan/,docs/reviewreport/(new) — Pandocdefinition.yaml,title.txt, andintroduction.mdfor each documentCI pipeline (
build.yaml)reviewmarkto thebuild-docsversion capture commandAgent and requirements
.github/agents/code-review-agent.md(new) — structured review checklist agent usingdotnet reviewmark --elaborateAGENTS.md— adds Code Review Agent to available agents and selection guiderequirements.yaml— addsVersionMark-OTS-ReviewMarkrequirement linked toReviewMark_ReviewPlanGenerationandReviewMark_ReviewReportGeneration.cspell.json— addsreviewmark/ReviewMarkto word listType of Change
Pre-Submission Checklist
Before submitting this pull request, ensure you have completed the following:
Build and Test
dotnet build --configuration Releasedotnet test --configuration Releasedotnet run --project src/DemaConsulting.VersionMark --configuration Release --framework net10.0--no-build -- --validateCode Quality
dotnet format --verify-no-changesQuality Checks
Please run the following checks before submitting:
cspell "**/*.{md,cs}"markdownlint "**/*.md"yamllint .Testing
Documentation
Additional Notes
No source code changes — infrastructure and configuration only.
versionmarkis excluded from.versionmark.yamltool capture because this is the VersionMark repository itself; the build determines its own version.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.