Fix post mortem location after exception inside load
#562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build against ruby-head seems broken, but it seems unrelated to this PR. I'll investigate it. |
deivid-rodriguez
force-pushed
the
fix_post_mortem_location
branch
from
6607002
to
880f645
Compare
|
ruby-head build was fixed in #563. |
|
Posted a ticket and potential fix to ruby-core: https://bugs.ruby-lang.org/issues/15885 |
|
Even if this is fixed in core, we'll want to workaround this until the fix is included in all supported rubies, so merging. |
deivid-rodriguez
force-pushed
the
fix_post_mortem_location
branch
from
880f645
to
316ce18
Compare
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 20, 2020
Update ruby-byebug to 11.1.0. ## [11.1.0] - 2020-01-20 ### Added * Official support for MRI 2.7 ([@yui-knk]). ### Fixed * [#562](deivid-rodriguez/byebug#562): post mortem mode landing in the wrong line when coming from an exception inside a `Kernel.load` call. ### Removed * Support for MRI 2.3. Byebug no longer installs on this platform.
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 27, 2020
Update ruby-byebug to 11.1.0. ## [11.1.0] - 2020-01-20 ### Added * Official support for MRI 2.7 ([@yui-knk]). ### Fixed * [#562](deivid-rodriguez/byebug#562): post mortem mode landing in the wrong line when coming from an exception inside a `Kernel.load` call. ### Removed * Support for MRI 2.3. Byebug no longer installs on this platform.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After ruby/ruby@1998039, our post mortem debugging partially broke, because ruby started emitting two
:raiseevents when an exception would happen during aloadcall. In this situation, the second:raiseevent would overwrite the first one, and the context location would be incorrect, leaving the user in an unexpected location.We fix the issue by watching for the case where we have already saved the context to the raised exception, and avoiding the overwrite.
Fixes #165.