Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Mortem support broken in rubies >= 2.2.4 #165

Closed
deivid-rodriguez opened this issue Aug 18, 2015 · 2 comments · Fixed by #562
Closed

Post Mortem support broken in rubies >= 2.2.4 #165

deivid-rodriguez opened this issue Aug 18, 2015 · 2 comments · Fixed by #562
Labels
help wanted

Comments

@deivid-rodriguez
Copy link
Owner

We're getting one test failure against latest ruby-head (https://travis-ci.org/deivid-rodriguez/byebug/jobs/76083918). Needs investigation.
deivid-rodriguez pushed a commit that referenced this issue Oct 19, 2015
Scripts to git bisect test failure in ruby-head
24308a3 
From Travis history we pick the last good revision (da70f4d) and the
first bad revision (f7c3b6f). Running `script/bisect.sh da70f4d f7c3b6f`
gave us the commit in ruby-core that broke the build:
http://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/51292

This seems most likely a bug in Ruby, but I still need to investigate
more.

Refs: #165
@deivid-rodriguez
Copy link
Owner Author

The test is broken since https://bugs.ruby-lang.org/projects/ruby-trunk/repository/revisions/51292. It seems that the backtrace provided by the Debug Inspector API (https://github.com/deivid-rodriguez/byebug/blob/master/ext/byebug/byebug.c#L445) is no longer complete when a raise event happens. It only includes frames up to the last load call, but not the frames inside it where the exception actually happened.

@nobu Any ideas? Not sure whether this is a problem in byebug or in ruby.

@deivid-rodriguez deivid-rodriguez changed the title Ruby 2.3 support Post Mortem support broken in rubies >= 2.2.4 Dec 19, 2015
@deivid-rodriguez
Copy link
Owner Author

Looks like the patch breaking this was backported to 2.2.4 as well, so post mortem support is now broken in all rubies >= 2.2.4

@deivid-rodriguez deivid-rodriguez mentioned this issue Jan 16, 2016
Open
@RedFred7 RedFred7 mentioned this issue Mar 25, 2016
Closed
@deivid-rodriguez deivid-rodriguez mentioned this issue May 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix post mortem location after exception inside load deivid-rodriguez/byebug
1 participant
@deivid-rodriguez