Rename functions that conflict with debase's #447
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my last pullrequest (#443), I fixed conflict with debase by renaming context initializer functions(e.g. Init_context() => Init_byebug_context()).
But I missed to fix other functions to conflict with debase's, for example Init_breakpoint(). So breakpoint isn't worked when using with debase.
I fixed it on this PR. On this PR, we can use byebug with debase completely.
Fixed point(rename) is the following
I think extern function name is unique globally as much as possible because C doesn't have namespace to function name.
For example, on msgpack-ruby(https://github.com/msgpack/msgpack-ruby), there is some functions that is prefixed with
MessagePack
ormsgpack
.So ideally we may rename all extern function name by adding prefix(e.g. byebug_xxx()).
But I fixed only functions that conflict with debase now.
(I don't know the reason, some functions is the same as debase's.)